Attachment 90634 Details for Bug 22945 – Eliminates both error messages. Looks good, thanks Owen.

[patch] Eliminates both error messages. Looks good, thanks Owen.

Bug-22945-Markup-error-in-OPAC-search-results-arou.patch (text/plain), 3.22 KB, created by Lucas Gass (lukeg) on 2019-06-14 21:24:23 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Lucas Gass (lukeg)

Created: 2019-06-14 21:24:23 UTC

Size: 3.22 KB

patch

obsolete

>From a161665576a580b744fd82f0097418541a72dd49 Mon Sep 17 00:00:00 2001
>From: Owen Leonard <oleonard@myacpl.org>
>Date: Tue, 21 May 2019 12:07:10 +0000
>Subject: [PATCH] Bug 22945: Markup error in OPAC search results around lists
> display
>
>This patch makes minor corrections to the template for OPAC search
>results. These corrections fix errors returned by the HTML validator.
>
>To reproduce the problem, perform a search in the OPAC which will return
>results which are on one or more lists. Run the page through the W3C
>validation service: https://validator.w3.org. Either by pasting in the
>URL for the search results (if web accessible) or by viewing source,
>copying, and pasting into "Validate by Direct Input."
>
>This patch addresses two specific errors:
>
> - "Text not allowed in element ul in this context."
> - "Stray end tag span."
>
>To test, apply the patch and try again to reproduce the validation
>errors. Those errors should no longer be present. There should be no
>visible change to the search results view.
>
>Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
>---
> koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt | 13 +++++++------
> 1 file changed, 7 insertions(+), 6 deletions(-)
>
>diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt
>index e6bd51b2d9..9595b2a5a9 100644
>--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt
>+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt
>@@ -489,13 +489,14 @@
>                                                 [% IF Koha.Preference('virtualshelves') AND SEARCH_RESULT.shelves.count %]
>                                                     <div class="results_summary shelves">
>                                                         <span class="label">Lists:</span>
>-                                                            <ul>
>-                                                                [% FOREACH shelf IN SEARCH_RESULT.shelves %]
>-                                                                    <li><a href="/cgi-bin/koha/opac-shelves.pl?op=view&amp;shelfnumber=[% shelf.shelfnumber | uri %]">[% shelf.shelfname | html %]</a></li>
>+                                                        <ul>
>+                                                            [% FOREACH shelf IN SEARCH_RESULT.shelves %]
>+                                                                <li>
>+                                                                    <a href="/cgi-bin/koha/opac-shelves.pl?op=view&amp;shelfnumber=[% shelf.shelfnumber | uri %]">[% shelf.shelfname | html %]</a>
>                                                                     [%~ UNLESS loop.last %], [% ELSE %].[% END ~%]
>-                                                                [% END %]
>-                                                            </ul>
>-                                                        </span>
>+                                                                </li>
>+                                                            [% END %]
>+                                                        </ul>
>                                                     </div>
>                                                 [% END %]
> 
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 22945: 89934 | 90634 | 90698