Attachment 90653 Details for Bug 21073 – Bug 21073: (QA follow-up) Atomic update shouldn't fail if plugins are disabled

[patch] Bug 21073: (QA follow-up) Atomic update shouldn't fail if plugins are disabled

Bug-21073-QA-follow-up-Atomic-update-shouldnt-fail.patch (text/plain), 2.00 KB, created by Tomás Cohen Arazi (tcohen) on 2019-06-17 11:21:23 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Tomás Cohen Arazi (tcohen)

Created: 2019-06-17 11:21:23 UTC

Size: 2.00 KB

patch

obsolete

>From df10f8bfe4d4cf926aa5432104c9ad5643beb6c8 Mon Sep 17 00:00:00 2001
>From: Tomas Cohen Arazi <tomascohen@theke.io>
>Date: Thu, 2 May 2019 11:42:18 -0300
>Subject: [PATCH] Bug 21073: (QA follow-up) Atomic update shouldn't fail if
> plugins are disabled
>
>Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
>Signed-off-by: Agustin Moyano <agustinmoyano@theke.io>
>Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
>---
> .../mysql/atomicupdate/plugin_methods.perl    | 23 ++++++++++---------
> 1 file changed, 12 insertions(+), 11 deletions(-)
>
>diff --git a/installer/data/mysql/atomicupdate/plugin_methods.perl b/installer/data/mysql/atomicupdate/plugin_methods.perl
>index 03f80a9d11..6d10bf2d82 100644
>--- a/installer/data/mysql/atomicupdate/plugin_methods.perl
>+++ b/installer/data/mysql/atomicupdate/plugin_methods.perl
>@@ -1,18 +1,19 @@
>-$DBversion = 'XXX';  # will be replaced by the RM
>+$DBversion = 'XXX';
> if( CheckVersion( $DBversion ) ) {
> 
>-    $dbh->do(q{
>-        CREATE TABLE IF NOT EXISTS plugin_methods (
>-          plugin_class varchar(255) NOT NULL,
>-          plugin_method varchar(255) NOT NULL,
>-          PRIMARY KEY ( `plugin_class` (191), `plugin_method` (191) )
>-        ) ENGINE=InnoDB DEFAULT CHARSET=utf8mb4 COLLATE=utf8mb4_unicode_ci;
>-    });
>+    unless ( TableExists('plugin_methods') ) {
>+        $dbh->do(q{
>+            CREATE TABLE plugin_methods (
>+              plugin_class varchar(255) NOT NULL,
>+              plugin_method varchar(255) NOT NULL,
>+              PRIMARY KEY ( `plugin_class` (191), `plugin_method` (191) )
>+            ) ENGINE=InnoDB DEFAULT CHARSET=utf8mb4 COLLATE=utf8mb4_unicode_ci;
>+        });
>+    }
> 
>     require Koha::Plugins;
>-    Koha::Plugins->new()->InstallPlugins;
>+    Koha::Plugins->new({ enable_plugins => 1 })->InstallPlugins;
> 
>-    # Always end with this (adjust the bug info)
>     SetVersion( $DBversion );
>-    print "Upgrade to $DBversion done (Bug XXXXX - description)\n";
>+    print "Upgrade to $DBversion done (Bug 21073 - Improve plugin performance)\n";
> }
>-- 
>2.22.0

Actions: View | Diff | Splinter Review

Attachments on bug 21073: 76955 | 76956 | 76957 | 76958 | 76973 | 88379 | 88380 | 88381 | 89247 | 89251 | 89252 | 89255 | 89256 | 89272 | 89273 | 89274 | 89275 | 89276 | 89277 | 89278 | 89279 | 89786 | 89800 | 89801 | 89802 | 89803 | 89804 | 89805 | 89806 | 89807 | 89808 | 90630 | 90631 | 90650 | 90651 | 90652 | 90653 | 90654 | 90655 | 90656 | 90657 | 90658 | 90659 | 90660 | 90661 | 90662 | 90663 | 90664 | 90724 | 90725 | 90726 | 90727 | 90728 | 90729 | 90730 | 90731 | 90732 | 90733 | 90734 | 90735 | 90736 | 90737 | 90738 | 90739 | 90759 | 90816