Bugzilla – Attachment 90663 Details for
Bug 21073
Improve plugin performance
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 21073: (QA follow-up) Don't call -> twice!
Bug-21073-QA-follow-up-Dont-call---twice.patch (text/plain), 884 bytes, created by
Tomás Cohen Arazi (tcohen)
on 2019-06-17 11:22:08 UTC
(
hide
)
Description:
Bug 21073: (QA follow-up) Don't call -> twice!
Filename:
MIME Type:
Creator:
Tomás Cohen Arazi (tcohen)
Created:
2019-06-17 11:22:08 UTC
Size:
884 bytes
patch
obsolete
>From ef1d4709b0ee8ef892678f5830578f8136723eeb Mon Sep 17 00:00:00 2001 >From: Tomas Cohen Arazi <tomascohen@theke.io> >Date: Mon, 17 Jun 2019 08:17:43 -0300 >Subject: [PATCH] Bug 21073: (QA follow-up) Don't call -> twice! > >Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> >--- > Koha/Plugins/Handler.pm | 1 - > 1 file changed, 1 deletion(-) > >diff --git a/Koha/Plugins/Handler.pm b/Koha/Plugins/Handler.pm >index 30b9e8bb0c..aa4970c6fc 100644 >--- a/Koha/Plugins/Handler.pm >+++ b/Koha/Plugins/Handler.pm >@@ -66,7 +66,6 @@ sub run { > if ( $has_method ) { > load $plugin_class; > my $plugin = $plugin_class->new( { cgi => $cgi, enable_plugins => $args->{'enable_plugins'} } ); >- my @return = $plugin->$plugin_method( $params ); > return $plugin->$plugin_method( $params ); > } else { > warn "Plugin does not have method $plugin_method"; >-- >2.22.0
<b>You cannot view the attachment while viewing its details because your browser does not support IFRAMEs. <a href="attachment.cgi?id=90663">View the attachment on a separate page</a>.</b>
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 21073
:
76955
|
76956
|
76957
|
76958
|
76973
|
88379
|
88380
|
88381
|
89247
|
89251
|
89252
|
89255
|
89256
|
89272
|
89273
|
89274
|
89275
|
89276
|
89277
|
89278
|
89279
|
89786
|
89800
|
89801
|
89802
|
89803
|
89804
|
89805
|
89806
|
89807
|
89808
|
90630
|
90631
|
90650
|
90651
|
90652
|
90653
|
90654
|
90655
|
90656
|
90657
|
90658
|
90659
|
90660
|
90661
|
90662
|
90663
|
90664
|
90724
|
90725
|
90726
|
90727
|
90728
|
90729
|
90730
|
90731
|
90732
|
90733
|
90734
|
90735
|
90736
|
90737
|
90738
|
90739
|
90759
|
90816