Attachment 90699 Details for Bug 22851 – Bug 22851: Style navigation links in serials modules like same links in other modules

[patch] Bug 22851: Style navigation links in serials modules like same links in other modules

Bug-22851-Style-navigation-links-in-serials-module.patch (text/plain), 4.30 KB, created by Katrin Fischer on 2019-06-17 20:41:31 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Katrin Fischer

Created: 2019-06-17 20:41:31 UTC

Size: 4.30 KB

patch

obsolete

>From 0380827f01d58da6bbd9b55fb3bda729325885d8 Mon Sep 17 00:00:00 2001
>From: Owen Leonard <oleonard@myacpl.org>
>Date: Mon, 10 Jun 2019 16:49:36 +0000
>Subject: [PATCH] Bug 22851: Style navigation links in serials modules like
> same links in other modules
>
>This patch makes minor markup changes to the serials sidebar menu
>include so that links are displayed in a style consistent with similar
>menus in other areas of the staff client.
>
>This patch contains whitespace changes, so please use the "-w" flag when
>viewing the diff.
>
>To test, apply the patch and go to the Serials module. The links in the
>sidebar menu should be displayed in the same style as the corresponding
>menu on the Acquisitions home page.
>
>Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de>
>
>Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
>---
> .../prog/en/includes/serials-menu.inc              | 72 ++++++++++++----------
> 1 file changed, 38 insertions(+), 34 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/serials-menu.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/serials-menu.inc
>index e99b6141c7..7cfa647fac 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/includes/serials-menu.inc
>+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/serials-menu.inc
>@@ -1,36 +1,40 @@
>-[% IF ( subscriptionid ) %]
>-<ul>
>-<li><a href="serials-collection.pl?subscriptionid=[% subscriptionid | uri %]">Serial collection</a></li>
>-  [% UNLESS closed %]
>-    [% IF ( routing && CAN_user_serials_routing ) %]
>-        [% IF ( hasRouting ) %]
>-             <li><a href="/cgi-bin/koha/serials/routing.pl?subscriptionid=[% subscriptionid | uri %]">Edit routing list</a></li>
>-        [% ELSE %]
>-            <li><a href="/cgi-bin/koha/serials/routing.pl?subscriptionid=[% subscriptionid | uri %]&amp;op=new">Create routing list</a></li>
>+<div id="navmenu">
>+    <div id="navmenulist">
>+        [% IF ( subscriptionid ) %]
>+            <ul>
>+                <li><a href="serials-collection.pl?subscriptionid=[% subscriptionid | uri %]">Serial collection</a></li>
>+                [% UNLESS closed %]
>+                    [% IF ( routing && CAN_user_serials_routing ) %]
>+                        [% IF ( hasRouting ) %]
>+                            <li><a href="/cgi-bin/koha/serials/routing.pl?subscriptionid=[% subscriptionid | uri %]">Edit routing list</a></li>
>+                        [% ELSE %]
>+                            <li><a href="/cgi-bin/koha/serials/routing.pl?subscriptionid=[% subscriptionid | uri %]&amp;op=new">Create routing list</a></li>
>+                        [% END %]
>+                    [% END %]
>+                [% END %]
>+            </ul>
>         [% END %]
>-    [% END %]
>-  [% END %]
>-</ul>
>-[% END %]
> 
>-<ul>
>-    [% IF ( CAN_user_serials_claim_serials ) %]
>-	<li><a href="/cgi-bin/koha/serials/claims.pl">Claims</a></li>
>-    [% END %]
>-    [% IF ( CAN_user_serials_check_expiration ) %]
>-	<li><a href="/cgi-bin/koha/serials/checkexpiration.pl">Check expiration</a></li>
>-    [% END %]
>-    <li>
>-        <a href="/cgi-bin/koha/serials/subscription-frequencies.pl">
>-            Manage frequencies
>-        </a>
>-    </li>
>-    <li>
>-        <a href="/cgi-bin/koha/serials/subscription-numberpatterns.pl">
>-            Manage numbering patterns
>-        </a>
>-    </li>
>-    [% IF Koha.Preference('Mana') == 1 %]
>-        <li><a href="/cgi-bin/koha/serials/serials-search.pl?mana=1">Search on Mana</a></li>
>-    [% END %]
>-</ul>
>+        <ul>
>+            [% IF ( CAN_user_serials_claim_serials ) %]
>+                <li><a href="/cgi-bin/koha/serials/claims.pl">Claims</a></li>
>+            [% END %]
>+            [% IF ( CAN_user_serials_check_expiration ) %]
>+                <li><a href="/cgi-bin/koha/serials/checkexpiration.pl">Check expiration</a></li>
>+            [% END %]
>+            <li>
>+                <a href="/cgi-bin/koha/serials/subscription-frequencies.pl">
>+                    Manage frequencies
>+                </a>
>+            </li>
>+            <li>
>+                <a href="/cgi-bin/koha/serials/subscription-numberpatterns.pl">
>+                    Manage numbering patterns
>+                </a>
>+            </li>
>+            [% IF Koha.Preference('Mana') == 1 %]
>+                <li><a href="/cgi-bin/koha/serials/serials-search.pl?mana=1">Search on Mana</a></li>
>+            [% END %]
>+        </ul>
>+    </div>
>+</div>
>\ No newline at end of file
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 22851: 90461 | 90476 | 90699