Bugzilla – Attachment 90711 Details for
Bug 22617
Checkout notes pending dashboard link - error received even though manage_checkout_notes permission set
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 22617: Fix checkout notes typo in manage_checkout_notes permission usage
Bug-22617-Fix-checkout-notes-typo-in-managecheckou.patch (text/plain), 1.73 KB, created by
Mark Tompsett
on 2019-06-18 00:57:29 UTC
(
hide
)
Description:
Bug 22617: Fix checkout notes typo in manage_checkout_notes permission usage
Filename:
MIME Type:
Creator:
Mark Tompsett
Created:
2019-06-18 00:57:29 UTC
Size:
1.73 KB
patch
obsolete
>From 72b16e179f5d57314e51973cb6d4ea5c965ea621 Mon Sep 17 00:00:00 2001 >From: Fridolin Somers <fridolin.somers@biblibre.com> >Date: Fri, 14 Jun 2019 10:43:15 +0200 >Subject: [PATCH] Bug 22617: Fix checkout notes typo in manage_checkout_notes > permission usage > >When logged into the staff client with an account with full circulate permissions (and therefore including the manage_checkout_notes permission) an error occurs when clicking on the Checkout notes pending link. The account is logged out automatically with the message: "Error: you do not have permission to view this page. Log in as a different user". >The same error occurs for both the link on the home page dashboard and from the Circulation module button. Works as expected if Superlibrarian permission is set. > >This is just a typo in perl script : circulation instead of circulate > >Test plan : >1) Set preference "AllowCheckoutNotes" to "Allow" >2) Create a user with only permissions "catalogue" and "circulate > manage_checkout_notes" >3) Loggin with this user >4) Go to "Circulation" home page >5) Click on "Checkout notes" >6) You should be allowed to access > >Signed-off-by: Mark Tompsett <mtompset@hotmail.com> >--- > circ/checkout-notes.pl | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/circ/checkout-notes.pl b/circ/checkout-notes.pl >index 97fb925977..324d15e65b 100755 >--- a/circ/checkout-notes.pl >+++ b/circ/checkout-notes.pl >@@ -33,7 +33,7 @@ my ( $template, $loggedinuser, $cookie ) = get_template_and_user( > query => $query, > type => "intranet", > authnotrequired => 0, >- flagsrequired => { circulation => "manage_checkout_notes" }, >+ flagsrequired => { circulate => "manage_checkout_notes" }, > } > ); > >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 22617
:
90589
|
90711
|
90895