Bugzilla – Attachment 90788 Details for
Bug 23132
Encoding issues in facets with show more link
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 23132: Fix encoding issues in facets with show more link
Bug-23132-Fix-encoding-issues-in-facets-with-show-.patch (text/plain), 2.17 KB, created by
Julian Maurice
on 2019-06-19 13:15:32 UTC
(
hide
)
Description:
Bug 23132: Fix encoding issues in facets with show more link
Filename:
MIME Type:
Creator:
Julian Maurice
Created:
2019-06-19 13:15:32 UTC
Size:
2.17 KB
patch
obsolete
>From 5931434f773de25fe523d849fce21ffe2602f8e6 Mon Sep 17 00:00:00 2001 >From: Fridolin Somers <fridolin.somers@biblibre.com> >Date: Mon, 17 Jun 2019 16:28:22 +0200 >Subject: [PATCH] Bug 23132: Fix encoding issues in facets with show more link >MIME-Version: 1.0 >Content-Type: text/plain; charset=UTF-8 >Content-Transfer-Encoding: 8bit > >When one uses characters like Ã, ç ... the first searcshow up correctly but when you refine your search with "Show more", the encoding becomes bad and so, results of the search too. > >Test plan : > >Without the patch: >- check if you have your SysPref SearchEngine with Elasticsearch as value, >- put your SysPref FacetMaxCount at 10, >- search in the catalog "a" and then in Refine your search click on show more (just to see how it works), >- then search with special characters like "é", ç" ... and make the same test, the research should be wrong when you click on show more and the page is realoaded. > >Then apply the patch: >- and make the same with a classic reasearch, then with special characters, >- verify that when you click on show more the page isn't realoded and the reasearch is correct. >- same with show less >- and finnaly, add some facets and test show more/less > >Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> >--- > koha-tmpl/intranet-tmpl/prog/en/includes/facets.inc | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/facets.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/facets.inc >index ea7a46dbea..e67919c380 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/includes/facets.inc >+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/facets.inc >@@ -49,7 +49,7 @@ > [% END %] > [% IF ( facets_loo.expandable ) %] > <li class="showmore"> >- <a href="[% url | url %][% IF offset %]&offset=[% offset | uri %][% END %]&expand=[% facets_loo.expand | uri %]#[% facets_loo.type_id | uri %]">Show more</a> >+ <a href="[% url | $raw %][% IF offset %]&offset=[% offset | uri %][% END %]&expand=[% facets_loo.expand | uri %]#[% facets_loo.type_id | uri %]">Show more</a> > </li> > [% END %] > </ul></li> >-- >2.20.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 23132
:
90673
|
90767
| 90788