Attachment 90817 Details for Bug 23150 – Bug 23150: Do not consider gdpr_proc_consent a mandatory field

[patch] Bug 23150: Do not consider gdpr_proc_consent a mandatory field

Bug-23150-Do-not-consider-gdprprocconsent-a-mandat.patch (text/plain), 1.30 KB, created by Jonathan Druart on 2019-06-19 19:53:09 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Druart

Created: 2019-06-19 19:53:09 UTC

Size: 1.30 KB

patch

obsolete

>From 1d49457b263156f502f85888efc726e6555d641a Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Wed, 19 Jun 2019 14:49:15 -0500
>Subject: [PATCH] Bug 23150: Do not consider gdpr_proc_consent a mandatory
> field
>
>It introduced a regression in the patron's self modification feature.
>Patron's details are no longer modificable, the screen displays
>"You have not filled out all required fields. Please fill in all missing
>fields and resubmit."
>
>Test plan:
>- Set GDPR_Policy to either Enforced or Permissive
>- Set PatronSelfRegistrationBorrowerMandatoryField to empty
>- Set OPACPatronDetails to Allow
>- Log into the OPAC
>- Accept the GDPR screen
>- Go to opac-memberentry.pl, change something, submit modification
>request
>---
> opac/opac-memberentry.pl | 1 -
> 1 file changed, 1 deletion(-)
>
>diff --git a/opac/opac-memberentry.pl b/opac/opac-memberentry.pl
>index 7fc9226c29..dc9c680038 100755
>--- a/opac/opac-memberentry.pl
>+++ b/opac/opac-memberentry.pl
>@@ -366,7 +366,6 @@ sub GetMandatoryFields {
>       C4::Context->preference("PatronSelfRegistrationBorrowerMandatoryField");
> 
>     my @fields = split( /\|/, $BorrowerMandatoryField );
>-    push @fields, 'gdpr_proc_consent' if C4::Context->preference('GDPR_Policy');
> 
>     foreach (@fields) {
>         $mandatory_fields{$_} = 1;
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 23150: 90817 | 90846 | 90847 | 90889 | 90890