Attachment 90828 Details for Bug 23166 – Bug 23166: Replace the count of orders with Koha::Acq::Orders

[patch] Bug 23166: Replace the count of orders with Koha::Acq::Orders

Bug-23166-Replace-the-count-of-orders-with-KohaAcq.patch (text/plain), 1.76 KB, created by Jonathan Druart on 2019-06-20 02:37:48 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Druart

Created: 2019-06-20 02:37:48 UTC

Size: 1.76 KB

patch

obsolete

>From 4ec8a8db7a54ee646b4976e2d8d7d6b2fbd79b6a Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Wed, 19 Jun 2019 21:35:20 -0500
>Subject: [PATCH] Bug 23166: Replace the count of orders with Koha::Acq::Orders
>
>---
> catalogue/detail.pl | 28 ++++++++++------------------
> 1 file changed, 10 insertions(+), 18 deletions(-)
>
>diff --git a/catalogue/detail.pl b/catalogue/detail.pl
>index 3c2b2dc434..a579516141 100755
>--- a/catalogue/detail.pl
>+++ b/catalogue/detail.pl
>@@ -512,24 +512,16 @@ if ($StaffDetailItemSelection) {
>     }
> }
> 
>-my @allorders_using_biblio = GetOrdersByBiblionumber ($biblionumber);
>-my @deletedorders_using_biblio;
>-my @orders_using_biblio;
>-
>-foreach my $myorder (@allorders_using_biblio) {
>-    my $basket = $myorder->{'basketno'};
>-    if ((defined $myorder->{'datecancellationprinted'}) and  ($myorder->{'datecancellationprinted'} ne '0000-00-00') ){
>-        push @deletedorders_using_biblio, $myorder;
>-    }
>-    else {
>-        push @orders_using_biblio, $myorder;
>-    }
>-}
>+my $orders =
>+  Koha::Acquisition::Orders->search( { biblionumber => $biblionumber } );
> 
>-my $count_orders_using_biblio = scalar @orders_using_biblio ;
>-$template->param (countorders => $count_orders_using_biblio);
>-
>-my $count_deletedorders_using_biblio = scalar @deletedorders_using_biblio ;
>-$template->param (countdeletedorders => $count_deletedorders_using_biblio);
>+$template->param(
>+    countorders => $orders->search( {
>+        datecancellationprinted => [ undef, '0000-00-00' ]
>+    } )->count,
>+    countdeletedorders => $orders->search( {
>+        datecancellationprinted => [ { '!=' => [ -and => ( undef, '0000-00-00' ) ] } ]
>+    } )->count,
>+) if $orders->count;
> 
> output_html_with_http_headers $query, $cookie, $template->output;
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 23166: 90824 | 90825 | 90826 | 90827 | 90828 | 104365 | 104366 | 104367 | 104368 | 104369 | 104370 | 108991 | 108992 | 108993 | 108994 | 108995 | 108996 | 108997 | 108998 | 108999 | 109000 | 109001 | 109002 | 109019 | 109020 | 109021 | 109022 | 109023 | 109024 | 109025 | 109026 | 109037 | 109038 | 109039 | 109040 | 109041 | 109042 | 109043 | 109044 | 109045 | 109046 | 109047 | 109048 | 109049 | 109050 | 109058 | 109059