Bugzilla – Attachment 90836 Details for
Bug 15516
Allow to place a hold on first available item from a group of titles
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 15516: (follow-up) Fix reserve -> hold change
Bug-15516-follow-up-Fix-reserve---hold-change.patch (text/plain), 2.84 KB, created by
Aleisha Amohia
on 2019-06-20 02:56:45 UTC
(
hide
)
Description:
Bug 15516: (follow-up) Fix reserve -> hold change
Filename:
MIME Type:
Creator:
Aleisha Amohia
Created:
2019-06-20 02:56:45 UTC
Size:
2.84 KB
patch
obsolete
>From edac08efdfb0675f1c8f11f47a2aa1fdc86171af Mon Sep 17 00:00:00 2001 >From: Josef Moravec <josef.moravec@gmail.com> >Date: Fri, 21 Sep 2018 10:43:23 +0000 >Subject: [PATCH] Bug 15516: (follow-up) Fix reserve -> hold change > >Signed-off-by: Josef Moravec <josef.moravec@gmail.com> >Signed-off-by: Michal Denar <black23@gmail.com> > >Signed-off-by: Michal Denar <black23@gmail.com> >--- > circ/pendingreserves.pl | 4 ++-- > reserve/hold-group.pl | 2 +- > reserve/placerequest.pl | 2 +- > reserve/request.pl | 2 +- > 4 files changed, 5 insertions(+), 5 deletions(-) > >diff --git a/circ/pendingreserves.pl b/circ/pendingreserves.pl >index b962215..56e8d53 100755 >--- a/circ/pendingreserves.pl >+++ b/circ/pendingreserves.pl >@@ -197,7 +197,7 @@ my $strsth = > ORDER BY items.itemnumber SEPARATOR '|') l_enumchron, > GROUP_CONCAT(DISTINCT items.copynumber > ORDER BY items.itemnumber SEPARATOR '|') l_copynumber, >- reserves.reserve_group_id, >+ reserves.hold_group_id, > biblio.title, > biblio.author, > count(DISTINCT items.itemnumber) as icount, >@@ -264,7 +264,7 @@ while ( my $data = $sth->fetchrow_hashref ) { > holdingbranch => $data->{holdingbranch}, > homebranch => $data->{homebranch}, > itemnumber => $data->{itemnumber}, >- reserve_group_id => $data->{reserve_group_id}, >+ hold_group_id => $data->{hold_group_id}, > } > ); > } >diff --git a/reserve/hold-group.pl b/reserve/hold-group.pl >index fbffa13..49d33e4 100755 >--- a/reserve/hold-group.pl >+++ b/reserve/hold-group.pl >@@ -32,7 +32,7 @@ my ($template, $loggedinuser, $cookie) = get_template_and_user({ > }); > > my $hold_group_id = $cgi->param('hold_group_id'); >-my @reserves = GetHoldGroupHolds($hold_group_id); >+my @holds = GetHoldGroupHolds($hold_group_id); > > $template->param( > hold_group_id => $hold_group_id, >diff --git a/reserve/placerequest.pl b/reserve/placerequest.pl >index 8feaeb3..2849361 100755 >--- a/reserve/placerequest.pl >+++ b/reserve/placerequest.pl >@@ -77,7 +77,7 @@ if ( $type eq 'str8' && $borrower ) { > > my $hold_group_id; > if ($multi_hold && $requestany) { >- $hold_group_id = AddReserveGroup(); >+ $hold_group_id = AddHoldGroup(); > } > > foreach my $biblionumber ( keys %bibinfos ) { >diff --git a/reserve/request.pl b/reserve/request.pl >index b62da31..d137c9e 100755 >--- a/reserve/request.pl >+++ b/reserve/request.pl >@@ -618,7 +618,7 @@ foreach my $biblionumber (@biblionumbers) { > $reserve{itemtype} = $res->itemtype(); > $reserve{branchcode} = $res->branchcode(); > $reserve{object} = $res; >- $reserve{'reserve_group_id'} = $res->reserve_group_id; >+ $reserve{'hold_group_id'} = $res->hold_group_id; > > push( @reserveloop, \%reserve ); > } >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 15516
:
46392
|
47498
|
47570
|
47961
|
47962
|
47963
|
48097
|
48098
|
48448
|
48449
|
50094
|
50095
|
50096
|
53742
|
53743
|
53744
|
53770
|
53771
|
53772
|
53774
|
53775
|
53776
|
54977
|
55300
|
55304
|
55305
|
55306
|
55307
|
55308
|
55768
|
55769
|
55770
|
55771
|
55772
|
58799
|
58800
|
58801
|
58802
|
58803
|
59314
|
59315
|
59316
|
59317
|
59318
|
69902
|
69903
|
69904
|
69905
|
69906
|
72485
|
72486
|
72487
|
72488
|
72489
|
72491
|
79077
|
79078
|
79080
|
79081
|
79082
|
79083
|
79213
|
79214
|
79215
|
79216
|
79217
|
79218
|
79219
|
79220
|
79221
|
79222
|
81453
|
81454
|
81455
|
81456
|
81457
|
81458
|
81459
|
81460
|
81461
|
81462
|
81463
|
84554
|
84555
|
84556
|
84557
|
84558
|
84559
|
84560
|
84561
|
84562
|
84563
|
84564
|
87828
|
87829
|
87830
|
87831
|
87832
|
87833
|
87834
|
87835
|
87836
|
87837
|
87838
|
88038
|
88039
|
88125
|
88173
|
88174
|
88175
|
88176
|
88177
|
88178
|
88179
|
88180
|
88181
|
88182
|
88183
|
88184
|
88185
|
88186
|
90289
|
90290
|
90291
|
90292
|
90293
|
90294
|
90295
|
90296
|
90297
|
90298
|
90299
|
90300
|
90301
|
90302
|
90303
|
90829
|
90830
|
90831
|
90832
|
90833
|
90834
|
90835
|
90836
|
90837
|
90838
|
90839
|
90840
|
90841
|
90842
|
90843
|
90844
|
92783
|
92784
|
92785
|
92786
|
92787
|
92788
|
92789
|
92790
|
92791
|
92792
|
92793
|
92794
|
92795
|
92796
|
92797
|
92798
|
114513
|
114514
|
114515
|
114516
|
114517
|
114518
|
114585
|
114586
|
114603
|
114624
|
114625
|
114626
|
114627
|
114628
|
114629
|
114630
|
114631
|
114632
|
114633
|
114634
|
114635
|
114636
|
114637
|
114638
|
114639
|
114640
|
114641
|
114642
|
114643
|
114644
|
114645
|
114647
|
114648
|
114649
|
114650
|
114651
|
114652
|
114653
|
114654
|
114655
|
114656
|
114657
|
114658
|
114659
|
117423
|
117424
|
117425
|
117426
|
118281
|
118282
|
118283
|
118284
|
118285
|
118286
|
118350
|
118351
|
118352
|
118353
|
118354
|
118355
|
120368
|
120369
|
120370
|
120371
|
120372
|
120373
|
120574
|
120643
|
120644
|
120645
|
120646
|
120647
|
120648
|
120649
|
120650
|
120651
|
121523
|
121623
|
122097
|
122102
|
122627
|
128189
|
128190
|
128191
|
128192
|
128193
|
128194
|
128195
|
128196
|
128197
|
128198
|
128199
|
128200
|
128201
|
128202
|
128255
|
128256
|
128257
|
128258
|
128259
|
128260
|
128261
|
128262
|
128263
|
128264
|
128265
|
128266
|
128267
|
128268
|
128269
|
128285
|
128286
|
128287
|
128288
|
128289
|
128290
|
128291
|
128292
|
128293
|
128294
|
128295
|
128296
|
128297
|
128298
|
128299
|
138576
|
138577
|
138578
|
138579
|
138580
|
138581
|
138582
|
138583
|
138584
|
138585
|
138586
|
138587
|
138588
|
138589
|
138593
|
138594
|
138595
|
138596
|
138597
|
138738
|
138739
|
138740
|
138741
|
138742
|
138772
|
138868
|
138869
|
162076
|
162077
|
162078
|
162079
|
162080
|
162081
|
162082
|
162083
|
162084