Attachment 90867 Details for Bug 22946 – Bug 22946: Markup error in OPAC search results around selection links

[patch] Bug 22946: Markup error in OPAC search results around selection links

Bug-22946-Markup-error-in-OPAC-search-results-arou.patch (text/plain), 3.12 KB, created by Mark Tompsett on 2019-06-21 04:03:00 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Mark Tompsett

Created: 2019-06-21 04:03:00 UTC

Size: 3.12 KB

patch

obsolete

>From d7e3910c2a8067a83e9d9e01769ed3748b238abb Mon Sep 17 00:00:00 2001
>From: Owen Leonard <oleonard@myacpl.org>
>Date: Tue, 21 May 2019 12:39:09 +0000
>Subject: [PATCH] Bug 22946: Markup error in OPAC search results around
> selection links
>
>This patch makes minor corrections to the template for OPAC search
>results. These corrections fix errors returned by the HTML validator.
>
>To reproduce the problem, make sure holds and/or tags are enabled in the
>OPAC. Perform a search in the OPAC which will return multiple results.
>Run the page through the W3C validation service:
>https://validator.w3.org. Either by pasting in the URL for the search
>results (if web accessible) or by viewing source, copying, and pasting
>into "Validate by Direct Input."
>
>This patch addresses one specific error:
>
> - "Element div not allowed as child of element span in this context."
>
>To test, apply the patch and try again to reproduce the validation
>errors. Those errors should no longer be present. There should be no
>visible change to the search results view.
>
>Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
>---
> koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
>diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt
>index 9595b2a5a9..211f0d180f 100644
>--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt
>+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt
>@@ -189,15 +189,15 @@
>                                                 <span id="tagsel_span">
>                                                     <input id="tagsel_tag" class="disabled" type="submit" value="Tag"/>
>                                                 </span>
>-                                                <div id="tagsel_form" style="display:none">
>+                                                <span id="tagsel_form" style="display:none">
>                                                     <label for="tagsel_new">New tag:</label>
>                                                     <input type="text" name="tagsel_new" id="tagsel_new" maxlength="100" />
>                                                     <input id="tagsel_button" name="tagsel_button" class="tagsel_button btn btn-small" title="Add" type="submit" value="Add" />
>                                                     <a href="#" id="tagsel_cancel">(done)</a>
>-                                                </div>
>-                                                <div id="tagsel_status" class="tagsel_tatus" style="display:none;">
>+                                                </span>
>+                                                <span id="tagsel_status" class="tagsel_tatus" style="display:none;">
>                                                     Tag status here.
>-                                                </div>
>+                                                </span>
>                                             [% END %]
>                                         </span> 
>                                 </div> 
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 22946: 89942 | 90867 | 90888