Attachment 90876 Details for Bug 23140 – Bug 23140: Fix typo in branchcode parameters for print slip

[patch] Bug 23140: Fix typo in branchcode parameters for print slip

Bug-23140-Fix-typo-in-branchcode-parameters-for-pr.patch (text/plain), 3.18 KB, created by Marcel de Rooy on 2019-06-21 07:36:15 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Marcel de Rooy

Created: 2019-06-21 07:36:15 UTC

Size: 3.18 KB

patch

obsolete

>From 3cf917587519dcad5b434fa7384e115f28bc8943 Mon Sep 17 00:00:00 2001
>From: Nick Clemens <nick@bywatersolutions.com>
>Date: Mon, 17 Jun 2019 17:58:56 +0000
>Subject: [PATCH] Bug 23140: Fix typo in branchcode parameters for print slip
>Content-Type: text/plain; charset=utf-8
>
>To test:
>1 - Have [% branch.branchcode %] in your TRANSFERSLIP
>2 - Checkin an item from another branch (with AutomaticItemReturn = do )
>3 - Inspect the button in the browser to see the typo
>4 - Click 'Print slip'
>5 - Note the branchcode is not populated
>6 - Clear the transfer
>7 - Apply patch
>8 - Repeat
>9 - Note typo is fixed and slip correctly populated
>
>Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
>
>Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>---
> koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt
>index b4824f2f01..46aede9def 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt
>@@ -397,10 +397,10 @@
>                     <div class="modal-footer">
>                         [% IF !transfer %]
>                         <button type="submit" name="dotransfer" value="Yes" class="btn btn-default approve"><i class="fa fa-check"></i> Yes</button>
>-                        <button type="submit" name="dotransfer" value="Yes" class="btn btn-default print openWin" data-url="transfer-slip.pl?transferitem=[% itemnumber | html %]&amp;&amp;branchcode[% returnbranch | html %]&amp;op=slip"><i class="fa fa-print"></i> Yes, print slip</button><button type="submit" class="btn btn-default deny" name="notransfer" value="No"><i class="fa fa-times"></i> No</button>
>+                        <button type="submit" name="dotransfer" value="Yes" class="btn btn-default print openWin" data-url="transfer-slip.pl?transferitem=[% itemnumber | html %]&amp;&amp;branchcode=[% returnbranch | html %]&amp;op=slip"><i class="fa fa-print"></i> Yes, print slip</button><button type="submit" class="btn btn-default deny" name="notransfer" value="No"><i class="fa fa-times"></i> No</button>
>                         [% ELSE %]
>                         <button type="submit" class="btn btn-default approve"><i class="fa fa-check"></i> OK</button>
>-                        <button type="submit" name="dotransfer" value="Yes" class="btn btn-default print openWin" data-url="transfer-slip.pl?transferitem=[% itemnumber | html %]&amp;&amp;branchcode[% returnbranch | html %]&amp;op=slip"><i class="fa fa-print"></i> Print slip</button>
>+                        <button type="submit" name="dotransfer" value="Yes" class="btn btn-default print openWin" data-url="transfer-slip.pl?transferitem=[% itemnumber | html %]&amp;&amp;branchcode=[% returnbranch | html %]&amp;op=slip"><i class="fa fa-print"></i> Print slip</button>
>                         [% END %]
>                         <input type="hidden" name="return_date_override" value="[% return_date_override | html %]" />
>                         <input type="hidden" name="return_date_override_remember" value="[% return_date_override_remember | html %]" />
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 23140: 90686 | 90710 | 90876