Attachment 90900 Details for Bug 23177 – Bug 23177: (QA follow-up) Move rollback to the end

[patch] Bug 23177: (QA follow-up) Move rollback to the end

Bug-23177-QA-follow-up-Move-rollback-to-the-end.patch (text/plain), 1.34 KB, created by Martin Renvoize (ashimema) on 2019-06-21 11:32:41 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Martin Renvoize (ashimema)

Created: 2019-06-21 11:32:41 UTC

Size: 1.34 KB

patch

obsolete

>From e308923b19ad618f2443adb12211d3aa4279a5e2 Mon Sep 17 00:00:00 2001
>From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>Date: Fri, 21 Jun 2019 09:03:27 +0000
>Subject: [PATCH] Bug 23177: (QA follow-up) Move rollback to the end
>
>Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>---
> t/db_dependent/Circulation.t | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)
>
>diff --git a/t/db_dependent/Circulation.t b/t/db_dependent/Circulation.t
>index bc15512167..173b7d66a9 100755
>--- a/t/db_dependent/Circulation.t
>+++ b/t/db_dependent/Circulation.t
>@@ -3037,9 +3037,6 @@ subtest 'AddReturn should clear items.onloan for unissued items' => sub {
>     is( $item->onloan, undef, 'AddReturn did clear items.onloan' );
> };
> 
>-$schema->storage->txn_rollback;
>-C4::Context->clear_syspref_cache();
>-$cache->clear_from_cache('single_holidays');
> 
> subtest 'AddRenewal and AddIssuingCharge tests' => sub {
> 
>@@ -3318,3 +3315,7 @@ subtest 'CanBookBeIssued & RentalFeesCheckoutConfirmation' => sub {
>     is_deeply( $needsconfirmation, { RENTALCHARGE => '3' }, 'Item needs rentalcharge confirmation to be issued, increment' );
>     $itemtype->rentalcharge_daily('0')->store;
> };
>+
>+$schema->storage->txn_rollback;
>+C4::Context->clear_syspref_cache();
>+$cache->clear_from_cache('single_holidays');
>-- 
>2.20.1

Actions: View | Diff | Splinter Review

Attachments on bug 23177: 90880 | 90881 | 90882 | 90899 | 90900 | 90901 | 90902 | 92175