Bugzilla – Attachment 90908 Details for
Bug 23181
Unable to use payment library in ACCOUNT_PAYMENT or ACCOUNT_WRITEOFF notices
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 23181 - Unable to use payment library in ACCOUNT_PAYMENT or ACCOUNT_WRITEOFF notices
Bug-23181---Unable-to-use-payment-library-in-ACCOU.patch (text/plain), 1.16 KB, created by
Kyle M Hall (khall)
on 2019-06-21 12:53:16 UTC
(
hide
)
Description:
Bug 23181 - Unable to use payment library in ACCOUNT_PAYMENT or ACCOUNT_WRITEOFF notices
Filename:
MIME Type:
Creator:
Kyle M Hall (khall)
Created:
2019-06-21 12:53:16 UTC
Size:
1.16 KB
patch
obsolete
>From 7c14ca5767efd89e52c4c4ab7cb83cfa255f5c74 Mon Sep 17 00:00:00 2001 >From: Kyle M Hall <kyle@bywatersolutions.com> >Date: Fri, 21 Jun 2019 08:51:15 -0400 >Subject: [PATCH] Bug 23181 - Unable to use payment library in ACCOUNT_PAYMENT > or ACCOUNT_WRITEOFF notices > >Do to a simple semantic typo, the branches key will always be null for the tables key of the parameters for GetPreparedLetter. > >Test Plan: >1) Attempt to use [% branch.branchame %] in the ACCOUNT_PAYMENT notice >2) Note it produces no output >3) Apply this patch >4) Make another payment >5) You should now see the branche's name! >--- > Koha/Account.pm | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/Koha/Account.pm b/Koha/Account.pm >index 9d66e70f7c..ed77703bd4 100644 >--- a/Koha/Account.pm >+++ b/Koha/Account.pm >@@ -263,7 +263,7 @@ sub pay { > lang => $patron->lang, > tables => { > borrowers => $self->{patron_id}, >- branches => $self->{library_id}, >+ branches => $library_id, > }, > substitute => { > credit => $payment, >-- >2.20.1 (Apple Git-117)
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 23181
:
90908
|
91520
|
94967
|
94980
|
94981
|
95944