Attachment 90973 Details for Bug 23196 – Bug 23196: (follow-up) Add comments to highlight structure

[patch] Bug 23196: (follow-up) Add comments to highlight structure

Bug-23196-follow-up-Add-comments-to-highlight-stru.patch (text/plain), 3.89 KB, created by Mark Tompsett on 2019-06-24 18:35:12 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Mark Tompsett

Created: 2019-06-24 18:35:12 UTC

Size: 3.89 KB

patch

obsolete

>From 1464b8629f1674b8ddf0b949bd688af0ddf387e9 Mon Sep 17 00:00:00 2001
>From: Owen Leonard <oleonard@myacpl.org>
>Date: Mon, 24 Jun 2019 17:16:07 +0000
>Subject: [PATCH] Bug 23196: (follow-up) Add comments to highlight structure
>
>This follow-up adds a few comments to the markup in order to highlight
>and clarify the the HTML structure.
>
>To test, apply the patch and perform a diff against master using the
>'-w' flag:
>
>git diff -w origin/master
>
>You should only see the addition of HTML comments.
>
>Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
>---
> .../prog/en/modules/tools/batch_record_modification.tt       | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/batch_record_modification.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/batch_record_modification.tt
>index 729894d421..53762988eb 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/batch_record_modification.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/batch_record_modification.tt
>@@ -56,7 +56,7 @@
>                                 </div>
>                             [% END %]
> 
>-                        </div>
>+                        </div> 
>                     [% END %]
> 
>                     [% IF view == 'form' %]
>@@ -122,7 +122,7 @@
>                                     &nbsp;
>                                 </div>
> 
>-                            </div>
>+                            </div> 
> 
>                             <fieldset class="rows">
>                                 <legend>Use MARC Modification Template:</legend>
>@@ -143,7 +143,7 @@
>                                 <input type="submit" value="Continue" class="button" />
>                                 <a class="cancel" href="/cgi-bin/koha/tools/tools-home.pl">Cancel</a>
>                             </fieldset>
>-                        </form>
>+                        </form> 
>                     [% ELSIF view == 'list' %]
>                         [% IF records %]
>                             <form action="/cgi-bin/koha/tools/batch_record_modification.pl" method="post" id="process">
>@@ -200,7 +200,7 @@
>                                                 </tr>
>                                             [% END %]
>                                         </tbody>
>-                                    </table>
>+                                    </table> 
>                                     <div class="note"><i class="fa fa-exclamation"></i> Reminder: this action will modify all selected biblios!</div>
>                                 [% ELSE %]
>                                     <div id="toolbar">
>@@ -226,7 +226,7 @@
>                                                 </tr>
>                                             [% END %]
>                                         </tbody>
>-                                    </table>
>+                                    </table> 
>                                     <div class="note"><i class="fa fa-exclamation"></i> Reminder: this action will modify all selected authorities!</div>
>                                 [% END %]
>                                 <fieldset class="action">
>@@ -241,7 +241,7 @@
>                                     <div id="jobstatus" class="progress_panel">Job progress: <div id="jobprogress"></div> <span id="jobprogresspercent">0</span>%</div>
>                                     <div id="jobfailed"></div>
>                                 </div>
>-                            </form>
>+                            </form> 
>                         [% ELSE %]
>                             <div class="dialog message">
>                                 No records were modified. <a href="/cgi-bin/koha/tools/batch_record_modification.pl" title="New batch record modification">New batch record modification</a>
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 23196: 90965 | 90966 | 90972 | 90973 | 91036 | 91037