Bugzilla – Attachment 90978 Details for
Bug 22949
Markup error in OPAC course reserves template
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 22949: Markup error in OPAC course reserves template
Bug-22949-Markup-error-in-OPAC-course-reserves-tem.patch (text/plain), 2.50 KB, created by
Jonathan Druart
on 2019-06-24 19:56:29 UTC
(
hide
)
Description:
Bug 22949: Markup error in OPAC course reserves template
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2019-06-24 19:56:29 UTC
Size:
2.50 KB
patch
obsolete
>From 5f8c000cf6d9574ff860f729963df392d4601b2d Mon Sep 17 00:00:00 2001 >From: Owen Leonard <oleonard@myacpl.org> >Date: Tue, 21 May 2019 14:45:06 +0000 >Subject: [PATCH] Bug 22949: Markup error in OPAC course reserves template > >This patch adds a missing "=" in opac-course-reserves.tt in order to >quiet errors returned by the HTML validator. > >To reproduce the problem you should have one or more course reserves >available in the OPAC. Go to the course reserves page. Run the page >through the W3C validation service: https://validator.w3.org. Either by >pasting in the URL for the search results (if web accessible) or by >viewing source, copying, and pasting into "Validate by Direct Input." > >This patch addresses these errors: > > - 'Quote " in attribute name. Probable cause: Matching quote missing > somewhere earlier.' > - 'Attribute class"inst_surname" not allowed on element span at this > point.' > >To test, apply the patch and try again to reproduce the validation >errors. Those errors should no longer be present. There should be no >visible change to the page. > >Signed-off-by: frederik <frederik@inlibro.com> > >Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >--- > koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-course-reserves.tt | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-course-reserves.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-course-reserves.tt >index dffe80b72c..9f3b430ce3 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-course-reserves.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-course-reserves.tt >@@ -49,7 +49,7 @@ > <td>[% AuthorisedValues.GetByCode( 'TERM' c.term, 1 ) | html %]</td> > <td> > [% FOREACH i IN c.instructors %] >- <div class="instructor"><span class"inst_surname">[% i.surname | html %]</span>[% IF i.firstname %]<span class="instr_separator">, </span><span class="instr_firstname">[% i.firstname | html %]</span>[% END %]</div> >+ <div class="instructor"><span class="inst_surname">[% i.surname | html %]</span>[% IF i.firstname %]<span class="instr_separator">, </span><span class="instr_firstname">[% i.firstname | html %]</span>[% END %]</div> > [% END %] > </td> > <td>[% c.public_note | $raw %]</td> >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 22949
:
89944
|
90934
| 90978