Bugzilla – Attachment 90983 Details for
Bug 23199
Koha::Patron->store and uppercasesurname syspref
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 23199 : move uppercasesurname from memberentry.pl to Koha::Patron
Bug-23199--move-uppercasesurname-from-memberentryp.patch (text/plain), 1.91 KB, created by
Arthur Suzuki
on 2019-06-25 09:51:26 UTC
(
hide
)
Description:
Bug 23199 : move uppercasesurname from memberentry.pl to Koha::Patron
Filename:
MIME Type:
Creator:
Arthur Suzuki
Created:
2019-06-25 09:51:26 UTC
Size:
1.91 KB
patch
obsolete
>From 9a0725e03b952673c4e7cdeba021015c747a1159 Mon Sep 17 00:00:00 2001 >From: Arthur Suzuki <arthur.suzuki@biblibre.com> >Date: Tue, 25 Jun 2019 11:45:21 +0200 >Subject: [PATCH] Bug 23199 : move uppercasesurname from memberentry.pl to > Koha::Patron > >In memberentry.pl uppercasesurname transform is applied both on patron >creation and update (save || insert). > >Therefore I moved the transformation a bit earlier in Koha::Patron so >that it's apply both in "AddMember" and "ModMember" > >Same test plan applies >--- > Koha/Patron.pm | 8 ++++---- > members/memberentry.pl | 4 ---- > 2 files changed, 4 insertions(+), 8 deletions(-) > >diff --git a/Koha/Patron.pm b/Koha/Patron.pm >index 30e3d052f9..30d5038536 100644 >--- a/Koha/Patron.pm >+++ b/Koha/Patron.pm >@@ -193,11 +193,11 @@ sub store { > > $self->trim_whitespaces; > >- unless ( $self->in_storage ) { #AddMember >+ # Set surname to uppercase if uppercasesurname is true >+ $self->surname( uc($self->surname) ) >+ if C4::Context->preference("uppercasesurname"); > >- # Set surname to uppercase if uppercasesurname is true >- $self->surname = uc($self->surname) >- if C4::Context->preference("uppercasesurname"); >+ unless ( $self->in_storage ) { #AddMember > > # Generate a valid userid/login if needed > $self->generate_userid >diff --git a/members/memberentry.pl b/members/memberentry.pl >index 166302006b..442be451b3 100755 >--- a/members/memberentry.pl >+++ b/members/memberentry.pl >@@ -343,10 +343,6 @@ if ($op eq 'save' || $op eq 'insert'){ > } > } > >- if($newdata{surname} && C4::Context->preference('uppercasesurnames')) { >- $newdata{'surname'} = uc($newdata{'surname'}); >- } >- > if (C4::Context->preference("IndependentBranches")) { > unless ( C4::Context->IsSuperLibrarian() ){ > $debug and print STDERR " $newdata{'branchcode'} : ".$userenv->{flags}.":".$userenv->{branch}; >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 23199
:
90982
|
90983
|
90996
|
91170
|
91171
|
91172
|
91318
|
91319
|
91320