Attachment 90992 Details for Bug 22566 – Bug 22566: Rename 'report_email' to 'report_by_branch'

[patch] Bug 22566: Rename 'report_email' to 'report_by_branch'

Bug-22566-Rename-reportemail-to-reportbybranch.patch (text/plain), 1.85 KB, created by Nick Clemens (kidclamp) on 2019-06-25 12:41:49 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Nick Clemens (kidclamp)

Created: 2019-06-25 12:41:49 UTC

Size: 1.85 KB

patch

obsolete

>From 26c193147753b2e05ce0018bb779fbb31dc53f74 Mon Sep 17 00:00:00 2001
>From: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>Date: Tue, 18 Jun 2019 13:38:43 +0100
>Subject: [PATCH] Bug 22566: Rename 'report_email' to 'report_by_branch'
>
>To clarify the intention of this routine, lets rename it
>
>Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
>---
> misc/cronjobs/stockrotation.pl | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
>diff --git a/misc/cronjobs/stockrotation.pl b/misc/cronjobs/stockrotation.pl
>index 3143839c06..5cf6374b12 100755
>--- a/misc/cronjobs/stockrotation.pl
>+++ b/misc/cronjobs/stockrotation.pl
>@@ -278,9 +278,9 @@ sub report_full {
>     ];
> }
> 
>-=head3 report_email
>+=head3 report_by_branch
> 
>-  my $email_report = report_email($report, [$branch]);
>+  my $email_report = report_by_branch($report, [$branch]);
> 
> Returns an arrayref containing a header string, with basic report information,
> and any number of 'per_branch' strings, containing a detailed report about the
>@@ -298,7 +298,7 @@ No data in the database is manipulated by this procedure.
> 
> =cut
> 
>-sub report_email {
>+sub report_by_branch {
>     my ( $data, $branch ) = @_;
> 
>     my $out    = [];
>@@ -337,7 +337,7 @@ sub report_email {
> return a string containing details about the stockrotation items and their
> status for the branch identified by $BRANCHCODE.
> 
>-This helper procedure is only used from within `report_email`.
>+This helper procedure is only used from within `report_by_branch`.
> 
> No data in the database is manipulated by this procedure.
> 
>@@ -520,7 +520,7 @@ execute($data) if ($execute);
> 
> # Emit Reports
> my $out_report = {};
>-$out_report = report_email( $data, $branch ) if $report eq 'email';
>+$out_report = report_by_branch( $data, $branch ) if $report eq 'email';
> $out_report = report_full( $data, $branch ) if $report eq 'full';
> emit(
>     {
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 22566: 86923 | 90421 | 90422 | 90423 | 90433 | 90434 | 90435 | 90742 | 90743 | 90744 | 90745 | 90746 | 90747 | 90748 | 90749 | 90750 | 90751 | 90752 | 90753 | 90989 | 90990 | 90991 | 90992 | 90993 | 90994 | 90995