Attachment 91010 Details for Bug 23211 – Bug 23211: Prevent SIP/Transaction.t to fail randomly

[patch] Bug 23211: Prevent SIP/Transaction.t to fail randomly

Bug-23211-Prevent-SIPTransactiont-to-fail-randomly.patch (text/plain), 1.58 KB, created by Martin Renvoize (ashimema) on 2019-06-26 08:01:43 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Martin Renvoize (ashimema)

Created: 2019-06-26 08:01:43 UTC

Size: 1.58 KB

patch

obsolete

>From 466f99e44230968aeb51598e50f65d212941c5b4 Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Tue, 25 Jun 2019 17:43:41 -0500
>Subject: [PATCH] Bug 23211: Prevent SIP/Transaction.t to fail randomly
>
>The checkout failed because patron's category is the one used for statistics (category_type=X).
>
>To recreate the failure:
>modified: t/db_dependent/SIP/Transaction.t
>@ Transaction.t:37 @ subtest fill_holds_at_checkout => sub {
>     plan tests => 6;
>
>-    my $category = $builder->build({ source => 'Category' });
>+    my $category = $builder->build({ source => 'Category', value => { category_type => 'X' }});
>     my $branch   = $builder->build({ source => 'Branch' });
>     my $borrower = $builder->build({ source => 'Borrower', value =>{
>         branchcode => $branch->{branchcode},
>
>Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>---
> t/db_dependent/SIP/Transaction.t | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/t/db_dependent/SIP/Transaction.t b/t/db_dependent/SIP/Transaction.t
>index 0e78505cd4..076fb29c35 100755
>--- a/t/db_dependent/SIP/Transaction.t
>+++ b/t/db_dependent/SIP/Transaction.t
>@@ -34,7 +34,7 @@ subtest fill_holds_at_checkout => sub {
>     plan tests => 6;
> 
> 
>-    my $category = $builder->build({ source => 'Category' });
>+    my $category = $builder->build({ source => 'Category', value => { category_type => 'A' }});
>     my $branch   = $builder->build({ source => 'Branch' });
>     my $borrower = $builder->build({ source => 'Borrower', value =>{
>         branchcode => $branch->{branchcode},
>-- 
>2.20.1

Actions: View | Diff | Splinter Review

Attachments on bug 23211: 91006 | 91010