Attachment 91021 Details for Bug 23220 – Bug 23220: Prevent form submission before redirect

[patch] Bug 23220: Prevent form submission before redirect

Bug-23220-Prevent-form-submission-before-redirect.patch (text/plain), 1.59 KB, created by Owen Leonard on 2019-06-26 14:04:23 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Owen Leonard

Created: 2019-06-26 14:04:23 UTC

Size: 1.59 KB

patch

obsolete

>From 34e93ac676c95ece84d5e7e11829d3b6c16a93ab Mon Sep 17 00:00:00 2001
>From: Nick Clemens <nick@bywatersolutions.com>
>Date: Wed, 26 Jun 2019 12:49:14 +0000
>Subject: [PATCH] Bug 23220: Prevent form submission before redirect
>
>To test:
> 1 - Check in an item to generate a transfer (form another library, no floating)
> 2 - Check it in again, click 'Cancel transfer'
> 3 - It may or may not work
> 4 - To highlight the issue edit return.tt to add the delay line as below:
>	$('.cancel-transfer').on("click",function(e){
>		delay(5000);
>		window.location.href='/cgi-bin/koha/circ/returns.pl?itemnumber=[% itemnumber | html %]&amp;canceltransfer=1'
>	});
> 5 - Check in the item repeatedly, click 'Cancel transfer'
> 6 - View the item in the staff or opac and verify it remains in transit
> 7 - Undo changes above, apply patch
> 8 - Test 'Cancel transfer', note it works
> 9 - Add the delay back in, confirm it still works
>
>Signed-off-by: Owen Leonard <oleonard@myacpl.org>
>---
> koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt | 1 +
> 1 file changed, 1 insertion(+)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt
>index 46aede9..1e98107 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt
>@@ -962,6 +962,7 @@
>             });
> 
>             $('.cancel-transfer').on("click",function(e){
>+                e.preventDefault();
>                 window.location.href='/cgi-bin/koha/circ/returns.pl?itemnumber=[% itemnumber | html %]&amp;canceltransfer=1'
>             });
> 
>-- 
>2.1.4

Actions: View | Diff | Splinter Review

Attachments on bug 23220: 91017 | 91021 | 91034