Attachment 91035 Details for Bug 23183 – Bug 23183: Reindent cataloging.js

[patch] Bug 23183: Reindent cataloging.js

Bug-23183-Reindent-catalogingjs.patch (text/plain), 3.17 KB, created by Katrin Fischer on 2019-06-26 21:59:12 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Katrin Fischer

Created: 2019-06-26 21:59:12 UTC

Size: 3.17 KB

patch

obsolete

>From ece51b5f102094e012b9c3bee3748085728dca2e Mon Sep 17 00:00:00 2001
>From: Owen Leonard <oleonard@myacpl.org>
>Date: Fri, 21 Jun 2019 14:07:49 +0000
>Subject: [PATCH] Bug 23183: Reindent cataloging.js
>
>This patch makes some very minor corrections to indentation in
>cataloging.js, a JavaScript file used by the bibliographic and item
>records editors.
>
>To test, apply the patch and perform a diff against master using the
>'-w' flag:
>
>git diff -w origin/master
>
>There should be no changes reported.
>
>Signed-off-by: Nadine Pierre <nadine.pierre@inLibro.com>
>Signed-off-by: Bin Wen <bin.wen@inlibro.com>
>
>Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
>---
> koha-tmpl/intranet-tmpl/prog/js/cataloging.js | 38 +++++++++++++--------------
> 1 file changed, 19 insertions(+), 19 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/js/cataloging.js b/koha-tmpl/intranet-tmpl/prog/js/cataloging.js
>index b685c2ac73..b26c45bdc2 100644
>--- a/koha-tmpl/intranet-tmpl/prog/js/cataloging.js
>+++ b/koha-tmpl/intranet-tmpl/prog/js/cataloging.js
>@@ -12,7 +12,7 @@ function getFieldCode(tagDivId){
> 
> //returns the field and subfieldcode based upon subfield div id
> function getFieldAndSubfieldCode(subfieldDivId){
>- // format : subfield<tagnumber><subfieldnumber>...
>+    // format : subfield<tagnumber><subfieldnumber>...
>     return subfieldDivId.substr(8,3+1);
> }
> 
>@@ -76,23 +76,23 @@ function ExpandField(index) {
> }
> 
> var Select2Utils = {
>-  removeSelect2: function(element) {
>-    if ($.fn.select2) {
>-      var selects = element.getElementsByTagName('select');
>-      for (var i=0; i < selects.length; i++) {
>-        $(selects[i]).select2('destroy');
>-      }
>-    }
>-  },
>-
>-  initSelect2: function(element) {
>-    if ($.fn.select2) {
>-      var selects = element.getElementsByTagName('select');
>-      for (var i=0; i < selects.length; i++) {
>-        $(selects[i]).select2();
>-      }
>+    removeSelect2: function(element) {
>+        if ($.fn.select2) {
>+            var selects = element.getElementsByTagName('select');
>+            for (var i=0; i < selects.length; i++) {
>+                $(selects[i]).select2('destroy');
>+            }
>+        }
>+    },
>+
>+    initSelect2: function(element) {
>+        if ($.fn.select2) {
>+            var selects = element.getElementsByTagName('select');
>+            for (var i=0; i < selects.length; i++) {
>+                $(selects[i]).select2();
>+            }
>+        }
>     }
>-  }
> };
> 
> /**
>@@ -221,7 +221,7 @@ function CloneField(index, hideMarc, advancedMARCEditor) {
>                                     buttonDotOnClick = buttonDotOnClick.replace(re2,",'"+inputs[1].getAttribute('id')+"')");
> 
>                                     if(buttonDotOnClick){
>-                                            buttonDot.setAttribute('onclick',buttonDotOnClick);
>+                                        buttonDot.setAttribute('onclick',buttonDotOnClick);
>                                     }
>                                 }
>                             }
>@@ -557,6 +557,6 @@ function CheckMandatorySubfields(p){
>     return total;
> }
> 
>- $(document).ready(function() {
>+$(document).ready(function() {
>     $("input.input_marceditor, input.indicator").addClass('noEnterSubmit');
> });
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 23183: 90909 | 90926 | 90930 | 91035