Attachment 91053 Details for Bug 23226 – Bug 23226: Remove type attribute from script tags: Cataloging

[patch] Bug 23226: Remove type attribute from script tags: Cataloging

Bug-23226-Remove-type-attribute-from-script-tags-C.patch (text/plain), 2.08 KB, created by Owen Leonard on 2019-06-27 13:32:50 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Owen Leonard

Created: 2019-06-27 13:32:50 UTC

Size: 2.08 KB

patch

obsolete

>From a3b822cb66a1569a62475c8043cd827dfa6a2488 Mon Sep 17 00:00:00 2001
>From: Owen Leonard <oleonard@myacpl.org>
>Date: Thu, 27 Jun 2019 13:24:36 +0000
>Subject: [PATCH] Bug 23226: Remove type attribute from script tags: Cataloging
>
>This patch removes the "type" attribute from <script> tags one
>cataloging and one authorities template.
>
>To test, apply the patch and confirm that examples of affected pages
>work properly without any JavaScript errors in the browser console:
>
> - Cataloging -> Cataloging home page
> - Cataloging -> Cataloging home page -> Search results
> - Authorities -> New authority -> New from Z39.50/SRU
>
>Validating the HTML source of any of these pages should return no errors
>related to the "type" attribute.
>---
> koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbooks.tt         | 2 +-
> .../intranet-tmpl/prog/en/modules/cataloguing/z3950_auth_search.tt      | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbooks.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbooks.tt
>index de32f38..4615738 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbooks.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbooks.tt
>@@ -215,7 +215,7 @@
> </div>
> 
> [% MACRO jsinclude BLOCK %]
>-    <script type="text/javascript">
>+    <script>
> 
>          $(document).ready(function() {
>             //Set focus to cataloging search
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/z3950_auth_search.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/z3950_auth_search.tt
>index 349b1c2..482cae3 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/z3950_auth_search.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/z3950_auth_search.tt
>@@ -170,7 +170,7 @@
> [% MACRO jsinclude BLOCK %]
>     [% Asset.js("lib/jquery/plugins/jquery.checkboxes.min.js") | $raw %]
>     [% INCLUDE 'datatables.inc' %]
>-    <script type="text/javascript">
>+    <script>
>         $(document).ready(function(){
> 
>             $(".dropdown").on("hidden.bs.dropdown", function(){
>-- 
>2.1.4

Actions: View | Diff | Splinter Review

Attachments on bug 23226: 91053 | 91667 | 91809