Attachment 91135 Details for Bug 23083 – Bug 23083: Fix course reserve item editing if one of the value is set to UNCHANGED

[patch] Bug 23083: Fix course reserve item editing if one of the value is set to UNCHANGED

Bug-23083-Fix-course-reserve-item-editing-if-one-o.patch (text/plain), 1.91 KB, created by Martin Renvoize (ashimema) on 2019-07-01 09:03:31 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Martin Renvoize (ashimema)

Created: 2019-07-01 09:03:31 UTC

Size: 1.91 KB

patch

obsolete

>From e1b94666e6373b4a068b314ea9b2249943285f35 Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Wed, 19 Jun 2019 20:08:04 -0500
>Subject: [PATCH] Bug 23083: Fix course reserve item editing if one of the
> value is set to UNCHANGED
>
>Test plan:
>0: Do not apply the patches
>1: Create an item with itype, ccode, location, and holding branch set
>2: Create a course
>3: Add item to course, changing the values for itype, ccode, and location
>4: Click Edit for that item on course-details.pl
>5: Assign new values for itype, ccode, and location but leave the holding library dropdown set to LEAVE UNCHANGED
>6: Hit Save
>7: Back on course-details.pl, observe that the item is still showing the values set in step 3
>8: Apply this patch
>9: Repeat 4 to 6
>10: Back on course-details.pl, observe that the item is now showing the correct values
>11: Edit the course reserve again, setting new values for itype, ccode, and location and setting the holding library dropdown to whatever the holding library for the item is currently
>12: hit save
>13: On course-details.pl, see that the change actually happened, the item is now showing the values set in step 9
>
>Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>---
> C4/CourseReserves.pm | 11 ++++++-----
> 1 file changed, 6 insertions(+), 5 deletions(-)
>
>diff --git a/C4/CourseReserves.pm b/C4/CourseReserves.pm
>index 428d7e9d33..39630b63c9 100644
>--- a/C4/CourseReserves.pm
>+++ b/C4/CourseReserves.pm
>@@ -531,11 +531,12 @@ sub _UpdateCourseItem {
>       unless ($course_item);
>     $ci_id = $course_item->{'ci_id'} unless ($ci_id);
> 
>-
>-    my %mod_params;
>-    foreach (@FIELDS) {
>-        $mod_params{$_} = $params{$_};
>-    }
>+    my %mod_params =
>+      map {
>+        defined $params{$_} && $params{$_} ne ''
>+          ? ( $_ => $params{$_} )
>+          : ()
>+      } @FIELDS;
> 
>     ModItem( \%mod_params, undef, $course_item->{'itemnumber'} );
> }
>-- 
>2.20.1

Actions: View | Diff | Splinter Review

Attachments on bug 23083: 90818 | 90819 | 91134 | 91135 | 91309 | 91310