Attachment 9115 Details for Bug 7937 – [SIGNED-OFF] Bug 7937: Silence warns in OPAC error log (koha-opac-error_log)

[patch] [SIGNED-OFF] Bug 7937: Silence warns in OPAC error log (koha-opac-error_log)

SIGNED-OFF-Bug-7937-Silence-warns-in-OPAC-error-lo.patch (text/plain), 2.18 KB, created by Owen Leonard on 2012-04-11 13:05:13 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Owen Leonard

Created: 2012-04-11 13:05:13 UTC

Size: 2.18 KB

patch

obsolete

>From d5c29f3d7caad226ce50ff89aa0614b678cb9142 Mon Sep 17 00:00:00 2001
>From: Katrin Fischer <Katrin.Fischer.83@web.de>
>Date: Mon, 9 Apr 2012 23:11:03 +0200
>Subject: [PATCH] [SIGNED-OFF] Bug 7937: Silence warns in OPAC error log
> (koha-opac-error_log)
>Content-Type: text/plain; charset="utf-8"
>
>To reproduce:
>Access a detail page where at least some items are available and have
>no due date.
>
>Log:
>opac-detail.pl: Use of uninitialized value in concatenation (.) or string at
>/home/katrin/kohaclone/koha-tmpl/opac-tmpl/prog/en/modules/opac-detail.tt
>line 657.
>
>Signed-off-by: Owen Leonard <oleonard@myacpl.org>
>
>Entry in the log is gone after the patch is applied.
>---
> koha-tmpl/opac-tmpl/prog/en/modules/opac-detail.tt |    4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/koha-tmpl/opac-tmpl/prog/en/modules/opac-detail.tt b/koha-tmpl/opac-tmpl/prog/en/modules/opac-detail.tt
>index cc59fb2..726e88a 100644
>--- a/koha-tmpl/opac-tmpl/prog/en/modules/opac-detail.tt
>+++ b/koha-tmpl/opac-tmpl/prog/en/modules/opac-detail.tt
>@@ -719,7 +719,7 @@ YAHOO.util.Event.onContentReady("furtherm", function () {
>             [% IF ( itemdata_itemnotes ) %]<th id="item_notes">Notes</th>[% END %]
>             <th id="item_datedue">Date due</th>
>         </tr></thead>
>-	    <tbody>[% FOREACH ITEM_RESULT IN ITEM_RESULTS %]
>+        <tbody>[% FOREACH ITEM_RESULT IN ITEM_RESULTS %]
> 	    <tr>[% IF ( item_level_itypes ) %]<td>[% UNLESS ( noItemTypeImages ) %][% IF ( ITEM_RESULT.imageurl ) %]<img src="[% ITEM_RESULT.imageurl %]" title="[% ITEM_RESULT.description %]" alt="[% ITEM_RESULT.description %]" />[% END %][% END %] [% ITEM_RESULT.description %]</td>[% END %]
> 		<td>
>     [% UNLESS ( singleBranchMode ) %]
>@@ -741,7 +741,7 @@ YAHOO.util.Event.onContentReady("furtherm", function () {
> 		[% IF ( itemdata_copynumber ) %]<td>[% ITEM_RESULT.copynumber %]</td>[% END %]
> 		<td>[% INCLUDE 'item-status.inc' item = ITEM_RESULT %]</td>
> 		[% IF ( itemdata_itemnotes ) %]<td>[% ITEM_RESULT.itemnotes %]</td>[% END %]
>-		<td>[% ITEM_RESULT.datedue | $KohaDates %]</td>
>+        <td>[% IF ( ITEM_RESULT.datedue ) %][% ITEM_RESULT.datedue | $KohaDates %][% END %]</td>
> 	    </tr>
> 	    [% END %]</tbody>
> 	</table>
>-- 
>1.7.5.4

Actions: View | Diff | Splinter Review

Attachments on bug 7937: 9059 | 9060 | 9061 | 9063 | 9064 | 9065 | 9115 | 9134 | 9135 | 9141 | 9142 | 9143