Attachment 91182 Details for Bug 23077 – Bug 23077: Don't fill cardnumber with empty string

[patch] Bug 23077: Don't fill cardnumber with empty string

Bug-23077-Dont-fill-cardnumber-with-empty-string.patch (text/plain), 1.24 KB, created by Nick Clemens (kidclamp) on 2019-07-02 10:59:53 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Nick Clemens (kidclamp)

Created: 2019-07-02 10:59:53 UTC

Size: 1.24 KB

patch

obsolete

>From 19397bb4ad1d40fe703f67dd3a5ba436f72b0443 Mon Sep 17 00:00:00 2001
>From: Nick Clemens <nick@bywatersolutions.com>
>Date: Fri, 7 Jun 2019 12:19:28 +0000
>Subject: [PATCH] Bug 23077: Don't fill cardnumber with empty string
>
>To test:
>1 - Apply unit test patch only
>2 - prove the tests, they fail
>3 - Attempt to import the attached sample file
>4 - First patron may be imported, second will give error (or both will error)
>5 - If only one error, import agian, now both have error
>6 - Apply this patch
>7 - Prove tests, they pass!
>8 - Import the sample file
>9 - It succeeds!
>
>Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de>
>---
> Koha/Patrons/Import.pm | 1 +
> 1 file changed, 1 insertion(+)
>
>diff --git a/Koha/Patrons/Import.pm b/Koha/Patrons/Import.pm
>index fe63b9567e..d98e44d7c5 100644
>--- a/Koha/Patrons/Import.pm
>+++ b/Koha/Patrons/Import.pm
>@@ -132,6 +132,7 @@ sub import_patrons {
>                 }
>             }
>         }
>+        $borrower{cardnumber} = undef unless $borrower{cardnumber};
> 
>         # Check if borrower category code exists and if it matches to a known category. Pushing error to missing_criticals otherwise.
>         $self->check_borrower_category($borrower{categorycode}, $borrowerline, $line_number, \@missing_criticals);
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 23077: 90415 | 90416 | 90417 | 90418 | 90474 | 90475 | 91181 | 91182 | 91183 | 91315 | 91316 | 91317