Bugzilla – Attachment 91242 Details for
Bug 14419
Expanding facets (Show more) performs a new search
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 14419: (QA follow-up) Restore the link styling
Bug-14419-QA-follow-up-Restore-the-link-styling.patch (text/plain), 3.64 KB, created by
Josef Moravec
on 2019-07-03 21:01:40 UTC
(
hide
)
Description:
Bug 14419: (QA follow-up) Restore the link styling
Filename:
MIME Type:
Creator:
Josef Moravec
Created:
2019-07-03 21:01:40 UTC
Size:
3.64 KB
patch
obsolete
>From 875adff919a458fce653afcda247d2dd46f18b3b Mon Sep 17 00:00:00 2001 >From: Josef Moravec <josef.moravec@gmail.com> >Date: Wed, 3 Jul 2019 20:56:56 +0000 >Subject: [PATCH] Bug 14419: (QA follow-up) Restore the link styling > >Test plan: >Look at Show more/less links in facets, in opac and staff client >--> without this patch they are pure text, no styling, no hand cursor >--> with this patch it is link, but continues to work as before > >Signed-off-by: Josef Moravec <josef.moravec@gmail.com> >--- > koha-tmpl/intranet-tmpl/prog/en/includes/facets.inc | 4 ++-- > koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt | 3 ++- > koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-facets.inc | 4 ++-- > koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt | 3 ++- > 4 files changed, 8 insertions(+), 6 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/facets.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/facets.inc >index 3a27c40858..7b58d25839 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/includes/facets.inc >+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/facets.inc >@@ -53,10 +53,10 @@ > [% END %] > [% IF facets_loo.facets.size > 5 %] > <li class="moretoggle"> >- Show more >+ <a href="#"><strong>Show more</strong></a> > </li> > <li class="moretoggle" style="display:none"> >- Show less >+ <a href="#"><strong>Show less</strong></a> > </li> > [% END %] > </ul></li> >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt >index 31eb9edea1..6a182c17d7 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt >@@ -668,7 +668,8 @@ > var Sticky; > $(document).ready(function() { > >- $(".moretoggle").click(function() { >+ $(".moretoggle").click(function(e) { >+ e.preventDefault(); > $(this).siblings(".collapsible-facet").toggle(); > $(this).siblings(".moretoggle").toggle(); > $(this).toggle(); >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-facets.inc b/koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-facets.inc >index a9b107c69a..847ae0c211 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-facets.inc >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-facets.inc >@@ -62,10 +62,10 @@ > [% END %] > [% IF facets_loo.facets.size > 5 %] > <li class="moretoggle"> >- Show more >+ <a href="#"><strong>Show more</strong></a> > </li> > <li class="moretoggle" style="display:none"> >- Show less >+ <a href="#"><strong>Show less</strong></a> > </li> > [% END %] > </ul> >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt >index 3fc8b57b4d..2a56c23caf 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt >@@ -741,7 +741,8 @@ function highlightOn() { > [% END %] > $(document).ready(function(){ > >- $(".moretoggle").click(function(){ >+ $(".moretoggle").click(function(e){ >+ e.preventDefault(); > $(this).siblings(".collapsible-facet").toggle(); > $(this).siblings(".moretoggle").toggle(); > $(this).toggle(); >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 14419
:
40339
|
40425
|
91185
|
91234
|
91241
| 91242 |
96355