Bugzilla – Attachment 91251 Details for
Bug 23250
koha-create generates broken mysql password
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 23250: Just use an @ in the password
Bug-23250-Just-use-an--in-the-password.patch (text/plain), 1.47 KB, created by
Mark Tompsett
on 2019-07-04 00:35:35 UTC
(
hide
)
Description:
Bug 23250: Just use an @ in the password
Filename:
MIME Type:
Creator:
Mark Tompsett
Created:
2019-07-04 00:35:35 UTC
Size:
1.47 KB
patch
obsolete
>From decb9a7836db31f31a7be5325498ec3b6b022281 Mon Sep 17 00:00:00 2001 >From: Mark Tompsett <mtompset@hotmail.com> >Date: Thu, 4 Jul 2019 00:29:01 +0000 >Subject: [PATCH] Bug 23250: Just use an @ in the password > >Rather than try to use -y and symbols, since >older versions of pwgen don't have the -y, >Purposefully just shorten the generated >password to 15 characters and put @ on the end. >This avoids nasty shell globbing, fixes the >MySQL requiring a symbol by default in the >newer versions. > >While @ at the end is less secure, the >password portion providing security is >still 15 characters long. > >Before patch, password should have potentially >multiple ugly symbols in it. >After patch, when creating an instance, the >password will have an @ at the end of it. >--- > debian/scripts/koha-create | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > >diff --git a/debian/scripts/koha-create b/debian/scripts/koha-create >index 35572f223c..6551fea3ef 100755 >--- a/debian/scripts/koha-create >+++ b/debian/scripts/koha-create >@@ -579,10 +579,8 @@ if [ "$op" = create ] || [ "$op" = request ] || [ "$op" = use ] > then > if [ "$mysqlpwd" = "" ] > then >- # over-size, so when problematic chars are removed, >- # still likely 16 characters left. >- mysqlpwd="$(pwgen -s -y 32 1)" >- mysqlpwd="$(echo $mysqlpwd | tr -d :\'\\\<\>\/ | cut -c1-16)" >+ mysqlpwd="$(pwgen -s 15 1)" >+ mysqlpwd="$mysqlpwd@" > fi > else > mysqlpwd="$(getinstancemysqlpassword $name)" >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 23250
:
91250
|
91251
|
91284