Bugzilla – Attachment 91312 Details for
Bug 23248
opac-ISBDdetail.pl dies on invalid biblionumber
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 23248: (QA follow-up) Consolidate 404s
Bug-23248-QA-follow-up-Consolidate-404s.patch (text/plain), 1.52 KB, created by
Marcel de Rooy
on 2019-07-05 06:17:38 UTC
(
hide
)
Description:
Bug 23248: (QA follow-up) Consolidate 404s
Filename:
MIME Type:
Creator:
Marcel de Rooy
Created:
2019-07-05 06:17:38 UTC
Size:
1.52 KB
patch
obsolete
>From 785525200ff261e6e73c0316b97eec9a740f02b4 Mon Sep 17 00:00:00 2001 >From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >Date: Fri, 5 Jul 2019 06:07:25 +0000 >Subject: [PATCH] Bug 23248: (QA follow-up) Consolidate 404s >Content-Type: text/plain; charset=utf-8 > >Merging two conditions: biblionumber is empty or biblionumber cannot be >found. This make the strange int($biblionumber) unneeded. > >Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >--- > opac/opac-ISBDdetail.pl | 11 +++-------- > 1 file changed, 3 insertions(+), 8 deletions(-) > >diff --git a/opac/opac-ISBDdetail.pl b/opac/opac-ISBDdetail.pl >index 4305d8c483..c79167cd31 100755 >--- a/opac/opac-ISBDdetail.pl >+++ b/opac/opac-ISBDdetail.pl >@@ -59,11 +59,12 @@ use Koha::Biblios; > > my $query = CGI->new(); > my $biblionumber = $query->param('biblionumber'); >-if ( !$biblionumber ) { >+my $biblio; >+$biblio = Koha::Biblios->find( $biblionumber, { prefetch => [ 'metadata', 'items' ] } ) if $biblionumber; >+if( !$biblio ) { > print $query->redirect('/cgi-bin/koha/errors/404.pl'); > exit; > } >-$biblionumber = int($biblionumber); > > #open template > my ( $template, $loggedinuser, $cookie ) = get_template_and_user( >@@ -76,12 +77,6 @@ my ( $template, $loggedinuser, $cookie ) = get_template_and_user( > } > ); > >-my $biblio = Koha::Biblios->find( $biblionumber, { prefetch => [ 'metadata', 'items' ] } ); >-unless ( $biblio ) { >- print $query->redirect("/cgi-bin/koha/errors/404.pl"); >- exit; >-} >- > my $patron = Koha::Patrons->find($loggedinuser); > > my $opachiddenitems_rules; >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 23248
:
91156
|
91157
|
91293
|
91311
| 91312