Bugzilla – Attachment 9132 Details for
Bug 7354
Can't edit local use system preferences
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 7354: Can't edit local use system preferences
Bug-7354-Cant-edit-local-use-system-preferences.patch (text/plain), 2.22 KB, created by
Chris Cormack
on 2012-04-12 07:35:01 UTC
(
hide
)
Description:
Bug 7354: Can't edit local use system preferences
Filename:
MIME Type:
Creator:
Chris Cormack
Created:
2012-04-12 07:35:01 UTC
Size:
2.22 KB
patch
obsolete
>From 75c6452574ab6d89a26cfc2775303a906bf03d04 Mon Sep 17 00:00:00 2001 >From: Katrin Fischer <Katrin.Fischer.83@web.de> >Date: Thu, 12 Apr 2012 08:59:32 +0200 >Subject: [PATCH] Bug 7354: Can't edit local use system preferences > >Fixes adding and editing of local use system preferences and redirects to correct >page after saving. > >To test: >- Create a new local use system preference >- Edit an existing local use system preference from summary page >- Edit an existing local use system preference using 'Edit' >- Delete a local use system preference > >Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> >--- > admin/systempreferences.pl | 9 ++++----- > 1 files changed, 4 insertions(+), 5 deletions(-) > >diff --git a/admin/systempreferences.pl b/admin/systempreferences.pl >index f4069ae..5e3848d 100755 >--- a/admin/systempreferences.pl >+++ b/admin/systempreferences.pl >@@ -95,7 +95,7 @@ $tabsysprefs{AutoLocation} = "Admin"; > $tabsysprefs{DebugLevel} = "Admin"; > $tabsysprefs{SessionStorage} = "Admin"; > >-# This script is depricated so all of these prefs are lumped here to avoid their being displayed in the local use prefs tab >+# This script is deprecated so all of these prefs are lumped here to avoid their being displayed in the local use prefs tab > > $tabsysprefs{noItemTypeImages} = "Admin"; > $tabsysprefs{OPACBaseURL} = "Admin"; >@@ -693,9 +693,8 @@ if ( $op eq 'add_form' ) { > } > > $data->{'lang'} = $template->param('lang'); >- >- $template->param( GetPrefParams($data) ); >- >+ my $prefparams = GetPrefParams($data); >+ $template->param( %$prefparams ); > $template->param( searchfield => $searchfield ); > > ################## ADD_VALIDATE ################################## >@@ -746,7 +745,7 @@ if ( $op eq 'add_form' ) { > } > } > $sth->finish; >- print "Content-Type: text/html\n\n<META HTTP-EQUIV=Refresh CONTENT=\"0; URL=systempreferences.pl?tab=" . $tabsysprefs{ $input->param('variable') } . "\"></html>"; >+ print "Content-Type: text/html\n\n<META HTTP-EQUIV=Refresh CONTENT=\"0; URL=systempreferences.pl?tab=\"></html>"; > exit; > ################## DELETE_CONFIRM ################################## > # called by default form, used to confirm deletion of data in DB >-- >1.7.5.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 7354
:
6768
|
6769
|
6770
|
9131
| 9132