Bugzilla – Attachment 91321 Details for
Bug 23266
Add to cart fires twice on shelf page
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 23266: Add to cart fires twice on shelf page
Bug-23266-Add-to-cart-fires-twice-on-shelf-page.patch (text/plain), 3.17 KB, created by
Martin Renvoize (ashimema)
on 2019-07-05 07:53:04 UTC
(
hide
)
Description:
Bug 23266: Add to cart fires twice on shelf page
Filename:
MIME Type:
Creator:
Martin Renvoize (ashimema)
Created:
2019-07-05 07:53:04 UTC
Size:
3.17 KB
patch
obsolete
>From 49f04297663e16d55a6c09033a54490b54260988 Mon Sep 17 00:00:00 2001 >From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >Date: Thu, 4 Jul 2019 12:57:17 +0000 >Subject: [PATCH] Bug 23266: Add to cart fires twice on shelf page > >Remove some duplicate functionality between opac-bottom and opac-shelves. > >Test plan: >[1] Before this patch, add to cart from a shelf page. Observe that the > basket count is incremented with 2. >[2] After this patch, it should be incremented with 1. > >Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> >--- > koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt >index 8a02c31feb..54f507f199 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt >@@ -484,9 +484,9 @@ > > [% IF Koha.Preference( 'opacbookbag' ) == 1 %] > [% IF ( itemsloo.incart ) %] >- <span class="actions"><a class="addtocart cart[% itemsloo.biblionumber | html %] hidden" href="#" onclick="addRecord('[% itemsloo.biblionumber | html %]'); return false;">In your cart</a> <a class="cartRemove cartR[% itemsloo.biblionumber | html %] hidden" href="#" onclick="delSingleRecord('[% itemsloo.biblionumber | html %]'); return false;">(remove)</a></span> >+ <span class="actions"><a data-biblionumber="[% itemsloo.biblionumber | html %]" class="addtocart cart[% itemsloo.biblionumber | html %] hidden" href="#">In your cart</a> <a data-biblionumber="[% itemsloo.biblionumber | html %]" class="cartRemove cartR[% itemsloo.biblionumber | html %] hidden" href="#">(remove)</a></span> > [% ELSE %] >- <span class="actions"><a class="addtocart cart[% itemsloo.biblionumber | html %] hidden" href="#" onclick="addRecord('[% itemsloo.biblionumber | html %]'); return false;">Add to cart</a> <a style="display:none;" class="cartRemove cartR[% itemsloo.biblionumber | html %] hidden" href="#" onclick="delSingleRecord('[% itemsloo.biblionumber | html %]'); return false;">(remove)</a></span> >+ <span class="actions"><a data-biblionumber="[% itemsloo.biblionumber | html %]" class="addtocart cart[% itemsloo.biblionumber | html %] hidden" href="#">Add to cart</a> <a style="display:none;" data-biblionumber="[% itemsloo.biblionumber | html %]" class="cartRemove cartR[% itemsloo.biblionumber | html %] hidden" href="#">(remove)</a></span> > [% END %] > [% END # / IF opacbookbag %] > </span> <!-- / .results_summary .actions --> >-- >2.20.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 23266
:
91290
|
91321
|
91391