Bugzilla – Attachment 91353 Details for
Bug 23227
Remove type attribute from script tags: Reports
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 23227: Remove type attribute from script tags: Reports
Bug-23227-Remove-type-attribute-from-script-tags-R.patch (text/plain), 2.41 KB, created by
Frédérik Chénier
on 2019-07-05 18:17:09 UTC
(
hide
)
Description:
Bug 23227: Remove type attribute from script tags: Reports
Filename:
MIME Type:
Creator:
Frédérik Chénier
Created:
2019-07-05 18:17:09 UTC
Size:
2.41 KB
patch
obsolete
>From d790fdc30d6bddf616a6a14ed36efbed04eded49 Mon Sep 17 00:00:00 2001 >From: Owen Leonard <oleonard@myacpl.org> >Date: Thu, 27 Jun 2019 13:38:50 +0000 >Subject: [PATCH] Bug 23227: Remove type attribute from script tags: Reports > >This patch removes the "type" attribute from <script> tags in two >reports templates. > >To test, apply the patch and confirm that examples of affected pages >work properly without any JavaScript errors in the browser console: > > - Reports -> Dictionary > - Delete > - Specifying a date range for a date column > - Reports -> Items lost > - Report results > -> Datatables functionality > -> Selection tools for export > >Validating the HTML source of any of these pages should return no errors >related to the "type" attribute. > >Signed-off-by: Mark Tompsett <mtompset@hotmail.com> >Signed-off-by: frederik chenier <frederik.chenier@inlibro.com> >--- > koha-tmpl/intranet-tmpl/prog/en/modules/reports/dictionary.tt | 2 +- > koha-tmpl/intranet-tmpl/prog/en/modules/reports/itemslost.tt | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/dictionary.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/dictionary.tt >index 528bc1d4d0..ce2beddd67 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/dictionary.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/dictionary.tt >@@ -273,7 +273,7 @@ > > [% MACRO jsinclude BLOCK %] > [% INCLUDE 'calendar.inc' %] >- <script type="text/javascript"> >+ <script> > var MSG_CONFIRM_DELETE = _("Are you sure you want to delete this dictionary definition? This cannot be undone."); > > $(document).ready(function() { >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/itemslost.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/itemslost.tt >index 36d1f24f58..c12b677f34 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/itemslost.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/itemslost.tt >@@ -192,7 +192,7 @@ > [% INCLUDE 'columns_settings.inc' %] > [% Asset.js("js/table_filters.js") | $raw %] > [% Asset.js("lib/jquery/plugins/jquery.checkboxes.min.js") | $raw %] >- <script type='text/javascript'> >+ <script> > $(document).ready(function() { > var columns_settings = [% ColumnsSettings.GetColumns( 'reports', 'lostitems', 'lostitems-table', 'json' ) | $raw %]; > var lostitems_table = KohaTable("lostitems-table", { >-- >2.17.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 23227
:
91054
|
91299
|
91352
|
91353
|
91387