Bugzilla – Attachment 91396 Details for
Bug 18707
Background jobs post disabled inputs
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 18707: Background jobs post disabled inputs
Bug-18707-Background-jobs-post-disabled-inputs.patch (text/plain), 1.59 KB, created by
Katrin Fischer
on 2019-07-06 15:52:17 UTC
(
hide
)
Description:
Bug 18707: Background jobs post disabled inputs
Filename:
MIME Type:
Creator:
Katrin Fischer
Created:
2019-07-06 15:52:17 UTC
Size:
1.59 KB
patch
obsolete
>From f28549b390f93d0206801f9ea0b53bb1bb138b9e Mon Sep 17 00:00:00 2001 >From: Fridolin Somers <fridolin.somers@biblibre.com> >Date: Wed, 31 May 2017 16:24:51 +0200 >Subject: [PATCH] Bug 18707: Background jobs post disabled inputs > >For example, in Tools > Batch item modification input of deleted subfields are disabled. >This form is posted using background job via JS code. >Looks like this JS code converts a POST form into a GET URL, including inputs that are disabled : > >koha-tmpl/intranet-tmpl/prog/js/background-job-progressbar.js >function submitBackgroundJob(f) { >... >$(':input', f).each(function() { >... > >This patch add a :enabled to selector > >Test plan : ><to define> > >Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> > >Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> >--- > koha-tmpl/intranet-tmpl/prog/js/background-job-progressbar.js | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/js/background-job-progressbar.js b/koha-tmpl/intranet-tmpl/prog/js/background-job-progressbar.js >index df40e13e80..5ddb4053c2 100644 >--- a/koha-tmpl/intranet-tmpl/prog/js/background-job-progressbar.js >+++ b/koha-tmpl/intranet-tmpl/prog/js/background-job-progressbar.js >@@ -42,7 +42,7 @@ function submitBackgroundJob(f) { > > // gather up form submission > var inputs = []; >- $(':input', f).each(function() { >+ $(':input:enabled', f).each(function() { > if (this.type == 'radio' || this.type == 'checkbox') { > if (this.checked) { > inputs.push(this.name + '=' + encodeURIComponent(this.value)); >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 18707
:
63866
|
91065
| 91396