Attachment 91423 Details for Bug 23219 – Bug 23219: (QA Follow up) Cancel patrons holds when patron

[patch] Bug 23219: (QA Follow up) Cancel patrons holds when patron

0001-Bug-23219-QA-Follow-up-Cancel-patrons-holds-when-pat.patch (text/plain), 1.75 KB, created by Emmi Takkinen on 2019-07-09 06:37:19 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Emmi Takkinen

Created: 2019-07-09 06:37:19 UTC

Size: 1.75 KB

patch

obsolete

>From ce557626012c5d0caaf5a87454a586ccf4138c13 Mon Sep 17 00:00:00 2001
>From: Emmi <emmi.takkinen@outlook.com>
>Date: Tue, 9 Jul 2019 09:24:30 +0300
>Subject: [PATCH] Bug 23219: (QA Follow up) Cancel patrons holds when patron
> delete
>
>Adds test for patrons holds cancelation when patron is deleted.
>
>Test plan:
>Run t/db_dependent/Koha/Patrons.t
>---
> t/db_dependent/Koha/Patrons.t | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
>diff --git a/t/db_dependent/Koha/Patrons.t b/t/db_dependent/Koha/Patrons.t
>index c9dd9c9306..3969a1f9a2 100644
>--- a/t/db_dependent/Koha/Patrons.t
>+++ b/t/db_dependent/Koha/Patrons.t
>@@ -32,6 +32,7 @@ use C4::Biblio;
> use C4::Auth qw(checkpw_hash);
> 
> use Koha::Holds;
>+use Koha::Old::Holds;
> use Koha::Patrons;
> use Koha::Patron::Categories;
> use Koha::Database;
>@@ -369,7 +370,7 @@ subtest "move_to_deleted" => sub {
> };
> 
> subtest "delete" => sub {
>-    plan tests => 5;
>+    plan tests => 6;
>     t::lib::Mocks::mock_preference( 'BorrowersLog', 1 );
>     my $patron           = $builder->build( { source => 'Borrower' } );
>     my $retrieved_patron = Koha::Patrons->find( $patron->{borrowernumber} );
>@@ -389,6 +390,8 @@ subtest "delete" => sub {
> 
>     is( Koha::Patrons->find( $patron->{borrowernumber} ), undef, 'Koha::Patron->delete should have deleted the patron' );
> 
>+    is (Koha::Old::Holds->search( { reserve_id => $hold->{ reserve_id } } )->count, 1, q|Koha::Patron->delete should have cancelled patron's holds| );
>+
>     is( Koha::Holds->search( { borrowernumber => $patron->{borrowernumber} } )->count, 0, q|Koha::Patron->delete should have deleted patron's holds| );
> 
>     is( Koha::Virtualshelves->search( { owner => $patron->{borrowernumber} } )->count, 0, q|Koha::Patron->delete should have deleted patron's lists| );
>-- 
>2.17.1
>

Actions: View | Diff | Splinter Review

Attachments on bug 23219: 91175 | 91281 | 91331 | 91333 | 91351 | 91395 | 91423 | 91473 | 91474 | 91475