Bugzilla – Attachment 91424 Details for
Bug 23284
Duplicate test in t/db_dependent/Plugins.t
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 23284: Remove test duplication
Bug-23284-Remove-test-duplication.patch (text/plain), 1.69 KB, created by
Martin Renvoize (ashimema)
on 2019-07-09 07:28:13 UTC
(
hide
)
Description:
Bug 23284: Remove test duplication
Filename:
MIME Type:
Creator:
Martin Renvoize (ashimema)
Created:
2019-07-09 07:28:13 UTC
Size:
1.69 KB
patch
obsolete
>From 428d0e61125b9d3ec6816bff48477e771a2eb0fd Mon Sep 17 00:00:00 2001 >From: Martin Renvoize <martin.renvoize@ptfs-europe.com> >Date: Tue, 9 Jul 2019 08:26:15 +0100 >Subject: [PATCH] Bug 23284: Remove test duplication > >A duplicate test was introduced during rebaseing work on bug 21073 > >Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> >--- > t/db_dependent/Plugins.t | 23 +---------------------- > 1 file changed, 1 insertion(+), 22 deletions(-) > >diff --git a/t/db_dependent/Plugins.t b/t/db_dependent/Plugins.t >index d5f78f91a3..052b7eaa29 100755 >--- a/t/db_dependent/Plugins.t >+++ b/t/db_dependent/Plugins.t >@@ -25,7 +25,7 @@ use File::Temp qw( tempdir tempfile ); > use FindBin qw($Bin); > use Module::Load::Conditional qw(can_load); > use Test::MockModule; >-use Test::More tests => 52; >+use Test::More tests => 51; > > use C4::Context; > use Koha::Database; >@@ -90,27 +90,6 @@ subtest 'Version upgrade tests' => sub { > $schema->storage->txn_rollback; > }; > >-subtest 'Version upgrade tests' => sub { >- >- plan tests => 1; >- >- $schema->storage->txn_begin; >- >- my $plugin = Koha::Plugin::Test->new( { enable_plugins => 1, cgi => CGI->new } ); >- >- # make sure there's no version on the DB >- $schema->resultset('PluginData') >- ->search( { plugin_class => $plugin->{class}, plugin_key => '__INSTALLED_VERSION__' } ) >- ->delete; >- >- $plugin = Koha::Plugin::Test->new( { enable_plugins => 1, cgi => CGI->new } ); >- my $version = $plugin->retrieve_data('__INSTALLED_VERSION__'); >- >- is( $version, $plugin->get_metadata->{version}, 'Version has been populated correctly' ); >- >- $schema->storage->txn_rollback; >-}; >- > subtest 'is_enabled() tests' => sub { > > plan tests => 3; >-- >2.20.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 23284
: 91424