Bugzilla – Attachment 9143 Details for
Bug 7937
Silence warns in OPAC error log (koha-opac-error_log)
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[SIGNED OFF] Bug 7937: Fix warns in opac-reserve.pl
SIGNED-OFF-Bug-7937-Fix-warns-in-opac-reservepl.patch (text/plain), 1.64 KB, created by
Chris Cormack
on 2012-04-12 09:50:31 UTC
(
hide
)
Description:
[SIGNED OFF] Bug 7937: Fix warns in opac-reserve.pl
Filename:
MIME Type:
Creator:
Chris Cormack
Created:
2012-04-12 09:50:31 UTC
Size:
1.64 KB
patch
obsolete
>From f8fec84317ddd5e7ac411791895b622257c8aa09 Mon Sep 17 00:00:00 2001 >From: Katrin Fischer <Katrin.Fischer.83@web.de> >Date: Tue, 10 Apr 2012 07:17:58 +0200 >Subject: [PATCH] [SIGNED OFF] Bug 7937: Fix warns in opac-reserve.pl > >1) opac-reserve.pl: Use of uninitialized value in string ne at >/home/katrin/kohaclone/opac/opac-reserve.pl line 475. > >2) opac-reserve.pl: Use of uninitialized value $reservedfor in >string eq at /home/katrin/kohaclone/opac/opac-reserve.pl line 410 > >Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> >--- > opac/opac-reserve.pl | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > >diff --git a/opac/opac-reserve.pl b/opac/opac-reserve.pl >index 4e4d440..91f3569 100755 >--- a/opac/opac-reserve.pl >+++ b/opac/opac-reserve.pl >@@ -407,7 +407,7 @@ foreach my $biblioNum (@biblionumbers) { > my $ItemBorrowerReserveInfo = GetMemberDetails( $reservedfor, 0); > > # the item could be reserved for this borrower vi a host record, flag this >- if ($reservedfor eq $borrowernumber){ >+ if ($reservedfor && $reservedfor eq $borrowernumber){ > $itemLoopIter->{already_reserved} = 1; > } > >@@ -472,7 +472,7 @@ foreach my $biblioNum (@biblionumbers) { > $policy_holdallowed = 0; > } > >- if (IsAvailableForItemLevelRequest($itemNum) and $policy_holdallowed and CanItemBeReserved($borrowernumber,$itemNum) and ($itemLoopIter->{already_reserved} ne 1)) { >+ if (IsAvailableForItemLevelRequest($itemNum) and $policy_holdallowed and CanItemBeReserved($borrowernumber,$itemNum) and !$itemLoopIter->{already_reserved}) { > $itemLoopIter->{available} = 1; > $numCopiesAvailable++; > } >-- >1.7.5.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 7937
:
9059
|
9060
|
9061
|
9063
|
9064
|
9065
|
9115
|
9134
|
9135
|
9141
|
9142
| 9143