Attachment 91496 Details for Bug 23310 – Bug 23310: Reduce noise in Koha::Biblio

[patch] Bug 23310: Reduce noise in Koha::Biblio

Bug-23310-Reduce-noise-in-KohaBiblio.patch (text/plain), 1.50 KB, created by Mark Tompsett on 2019-07-12 16:52:32 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Mark Tompsett

Created: 2019-07-12 16:52:32 UTC

Size: 1.50 KB

patch

obsolete

>From 5a89305447f531f00a2b8636b7d1478ad8b15602 Mon Sep 17 00:00:00 2001
>From: Mark Tompsett <mtompset@hotmail.com>
>Date: Fri, 12 Jul 2019 01:30:47 +0000
>Subject: [PATCH] Bug 23310: Reduce noise in Koha::Biblio
>
>The use of uninitialized value flooding plack-error
>can get rather distracting and annoying.
>By using "// q{}" after each of the subfield() calls
>this eliminates the problem
>
>TEST PLAN
>---------
>vertical break where you stop your cut-and-paste.
>This test should be repeatable with cut-and-paste
>easily.
>
>echo | sudo tee /var/log/koha/kohadev/plack-error.log
>restart_all
>kshell
>
>prove t/db_dependent/Koha/Biblio.t
>cat /var/log/koha/kohadev/plack-error.log
>
>--- noise in plack-error log
>
>exit
>git bz apply 23310
>echo | sudo tee /var/log/koha/kohadev/plack-error.log
>restart_all
>kshell
>
>prove t/db_dependent/Koha/Biblio.t
>cat /var/log/koha/kohadev/plack-error.log
>
>--- no noise in plack-error log
>
>kshell
>
>qa -v 2 -c 1
>---
> Koha/Biblio.pm | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/Koha/Biblio.pm b/Koha/Biblio.pm
>index f38a101e27..ce472a7f58 100644
>--- a/Koha/Biblio.pm
>+++ b/Koha/Biblio.pm
>@@ -579,7 +579,7 @@ sub get_coins {
>                 push @authors, $au;
>             }
>         }
>-        $title = $record->subfield( '245', 'a' ) . $record->subfield( '245', 'b' );
>+        $title = $record->field('245')->as_string('ab');
>         if ($titletype eq 'a') {
>             $pubyear   = $record->field('008') || '';
>             $pubyear   = substr($pubyear->data(), 7, 4) if $pubyear;
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 23310: 91495 | 91496 | 91497 | 91544 | 91549