Bugzilla – Attachment 91723 Details for
Bug 23099
OPAC Search result sorting "go" button flashes on page load
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
This is much better. CSS is always greater than jQuery in these instances.
Bug-23099-OPAC-Search-result-sorting-go-button-fla.patch (text/plain), 3.46 KB, created by
Lucas Gass (lukeg)
on 2019-07-22 22:44:23 UTC
(
hide
)
Description:
This is much better. CSS is always greater than jQuery in these instances.
Filename:
MIME Type:
Creator:
Lucas Gass (lukeg)
Created:
2019-07-22 22:44:23 UTC
Size:
3.46 KB
patch
obsolete
>From 90c207a3c4025adea2b4d75bc65a14bc15d4d498 Mon Sep 17 00:00:00 2001 >From: Owen Leonard <oleonard@myacpl.org> >Date: Tue, 11 Jun 2019 18:13:08 +0000 >Subject: [PATCH] Bug 23099: OPAC Search result sorting "go" button flashes on > page load > >There are a few places in the OPAC where we hide the submit button on a >sorting form because the form auto-submits when the selection changes. >These should be hidden using CSS instead of JS to prevent the temporary >appearance of the submit button while the page loads. > >To test, apply the patch and rebuild the OPAC CSS >(https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). > >Test OPAC search results and OPAC checkout history. On both pages you >should not see a "Go" button next to the <select> input for changing the >sort order. > >Disable JavaScript in your browser and test those pages again. The "Go" >button should appear. > >Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> >--- > koha-tmpl/opac-tmpl/bootstrap/css/src/opac.scss | 8 ++++++++ > koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-readingrecord.tt | 1 - > koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results-grouped.tt | 1 - > koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt | 1 - > 4 files changed, 8 insertions(+), 3 deletions(-) > >diff --git a/koha-tmpl/opac-tmpl/bootstrap/css/src/opac.scss b/koha-tmpl/opac-tmpl/bootstrap/css/src/opac.scss >index 1e389c2ab9..f2fea4ab62 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/css/src/opac.scss >+++ b/koha-tmpl/opac-tmpl/bootstrap/css/src/opac.scss >@@ -17,12 +17,20 @@ $footer-height: 45px; > .selections-toolbar { > display: none; > } >+ >+ #sortsubmit { >+ display: inline; >+ } > } > > .js { > .dateformat { > display: none; > } >+ >+ #sortsubmit { >+ display: none; >+ } > } > > .fa.fa-icon-black, >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-readingrecord.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-readingrecord.tt >index 5a880b2a73..86f92fccc9 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-readingrecord.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-readingrecord.tt >@@ -210,7 +210,6 @@ > <script> > $(document).ready(function(){ > [% IF ( GoogleJackets ) %]KOHA.Google.GetCoverFromIsbn();[% END %] >- $('#sortsubmit').hide(); > $('#order').change(function() { > $('#sortform').submit(); > }); >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results-grouped.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results-grouped.tt >index 31194b9d97..8e4ac21a39 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results-grouped.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results-grouped.tt >@@ -297,7 +297,6 @@ $(document).ready(function(){ > }); > [% END %] > >- $('#sortsubmit').hide(); > $('#sort_by').change(function() { > $('#bookbag_form').submit(); > }); >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt >index 2a56c23caf..93ca736e47 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt >@@ -840,7 +840,6 @@ $(document).ready(function(){ > param1 += "<\/select> <input type=\"submit\" class=\"btn btn-small\" value=\""+_("Save")+"\" />"; > [% END %] > >- $('#sortsubmit').hide(); > $('.resort').change(function() { > $('#bookbag_form').submit(); > }); >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 23099
:
90516
|
91723
|
91865