Attachment 91748 Details for Bug 23363 – Bug 23363 - Fix Internal Server Error when clicking on shipment cost invoice link

[patch] Bug 23363 - Fix Internal Server Error when clicking on shipment cost invoice link

Bug-23363---Fix-Internal-Server-Error-when-clickin.patch (text/plain), 2.21 KB, created by Liz Rea (ByWater) on 2019-07-23 15:36:41 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Liz Rea (ByWater)

Created: 2019-07-23 15:36:41 UTC

Size: 2.21 KB

patch

obsolete

>From ad25346529bd393e08ccda0c9ae54a01d224b479 Mon Sep 17 00:00:00 2001
>From: Liz Rea <wizzyrea@gmail.com>
>Date: Tue, 23 Jul 2019 10:22:20 -0500
>Subject: [PATCH] Bug 23363 - Fix Internal Server Error when clicking on
> shipment cost invoice link
>
>To test:
>
>On the fund detail page, have some shipment costs associated with a fund
>
>an example would be cgi-bin/koha/acqui/spent.pl?fund=<your fund>&fund_code=<your
>code>
>
>Click the link for the fund, without this patch it will give an internal
>server error.
>
>With this patch, the shipment invoice will be loaded.
>---
> acqui/spent.pl                                         | 5 +++--
> koha-tmpl/intranet-tmpl/prog/en/modules/acqui/spent.tt | 2 +-
> 2 files changed, 4 insertions(+), 3 deletions(-)
>
>diff --git a/acqui/spent.pl b/acqui/spent.pl
>index 20d2b13c0c..ba843a8d72 100755
>--- a/acqui/spent.pl
>+++ b/acqui/spent.pl
>@@ -119,7 +119,7 @@ while ( my $data = $sth->fetchrow_hashref ) {
> 
> my $total = $subtotal;
> $query = qq{
>-    SELECT invoicenumber, shipmentcost
>+    SELECT invoiceid, invoicenumber, shipmentcost
>     FROM aqinvoices
>     WHERE shipmentcost_budgetid = ?
> };
>@@ -129,7 +129,8 @@ my @shipmentcosts;
> while (my $data = $sth->fetchrow_hashref) {
>     push @shipmentcosts, {
>         shipmentcost => sprintf("%.2f", $data->{shipmentcost}),
>-        invoicenumber => $data->{invoicenumber}
>+        invoiceid => $data->{invoiceid},
>+	invoicenumber => $data->{invoicenumber}
>     };
>     $total += $data->{shipmentcost};
> }
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/spent.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/spent.tt
>index 2e5ca3f830..6466080799 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/spent.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/spent.tt
>@@ -88,7 +88,7 @@
>                 <tr>
>                     <td></td>
>                     <td colspan="8">Shipping cost for invoice
>-                        <a href="/cgi-bin/koha/acqui/invoice.pl?invoiceid=[% shipmentcode.invoiceid | uri %]">
>+                        <a href="/cgi-bin/koha/acqui/invoice.pl?invoiceid=[% shipmentcost.invoiceid | uri %]">
>                              [% shipmentcost.invoicenumber | html %]
>                         </a>
>                     </td>
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 23363: 91748 | 91749 | 91772 | 91773