Bugzilla – Attachment 91812 Details for
Bug 23383
IdRef link appears even with syspref is off
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 23383: fix IdRef syspref test in XSLT
Bug-23383-fix-IdRef-syspref-test-in-XSLT.patch (text/plain), 1.59 KB, created by
Fridolin Somers
on 2019-07-26 13:50:16 UTC
(
hide
)
Description:
Bug 23383: fix IdRef syspref test in XSLT
Filename:
MIME Type:
Creator:
Fridolin Somers
Created:
2019-07-26 13:50:16 UTC
Size:
1.59 KB
patch
obsolete
>From 7e8d757468356d6967309aae738338cecf945533 Mon Sep 17 00:00:00 2001 >From: Fridolin Somers <fridolin.somers@biblibre.com> >Date: Fri, 26 Jul 2019 15:43:02 +0200 >Subject: [PATCH] Bug 23383: fix IdRef syspref test in XSLT > >IdRef link is displayed via XSLT. >There is a test of syspref with just if value is defined. >But in installer/data/mysql/sysprefs.sql you see this pref will be 0 by default, which is true in XPATH. >We should test that pref is 1. > >Test plan : >1) Create a fresh UNIMARC database >2) You have pref IdRef disabled >3) Simulate a SUDOC record: > Fill a 7..$3 field with a ppn (032581270 for example). > Fill the 009 field with an integer >4) Go to the opac detail page of the record => You don't see IdRef link >5) Enable IdRef syspref >6) Go to the opac detail page of the record => You see IdRef link >7) Disable IdRef syspref >8) Go to the opac detail page of the record => You don't see IdRef link >--- > koha-tmpl/opac-tmpl/bootstrap/en/xslt/UNIMARCslimUtils.xsl | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/xslt/UNIMARCslimUtils.xsl b/koha-tmpl/opac-tmpl/bootstrap/en/xslt/UNIMARCslimUtils.xsl >index 61f67eb3f3..b14b93fdba 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/xslt/UNIMARCslimUtils.xsl >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/xslt/UNIMARCslimUtils.xsl >@@ -383,7 +383,7 @@ > </xsl:if> > </xsl:for-each> > </a> >- <xsl:if test="$IdRef"> >+ <xsl:if test="$IdRef = '1'"> > <xsl:if test="marc:subfield[@code=3]"> > <xsl:text> </xsl:text> > <a> >-- >2.17.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 23383
:
91812
|
100329
|
100588