Bugzilla – Attachment 91846 Details for
Bug 23388
Make system preferences links
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 23388: Make system preferences links and give them anchors
Bug-23388-Make-system-preferences-links-and-give-t.patch (text/plain), 2.51 KB, created by
Maryse Simard
on 2019-07-26 21:27:11 UTC
(
hide
)
Description:
Bug 23388: Make system preferences links and give them anchors
Filename:
MIME Type:
Creator:
Maryse Simard
Created:
2019-07-26 21:27:11 UTC
Size:
2.51 KB
patch
obsolete
>From 3b7e3712928d8f59a3f0d84787ebd22d68df80c5 Mon Sep 17 00:00:00 2001 >From: Nick Clemens <nick@bywatersolutions.com> >Date: Fri, 26 Jul 2019 18:23:41 +0000 >Subject: [PATCH] Bug 23388: Make system preferences links and give them > anchors > >FIXME: Note the floating toolbar actually breaks this because it hides the anchored pref. Add this CSS to IntrnateUSerCSS to fix it > > padding-top: 50px; > margin-top: -50px; >} > >To test: >1 - Search for 'fields' >2 - Scroll to 'PatronQuickAddFields' >3 - You don't have a way to share a link to this pref >4 - You can't view th other patron prefs without scrolling back to tabs >5 - Apply patch >6 - Repeat >7 - Note the pref is a link you can copy >8 - Click it >9 - You are now on the tab for the pref >10 - Click on other prefs and you focus on them > >Signed-off-by: Maryse Simard <maryse.simard@inlibro.com> >--- > koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences.tt | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences.tt >index 764f164..3792e7e 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences.tt >@@ -52,16 +52,16 @@ > [% ELSE %] > [% IF ( loop.first ) %]<table class="preferences"><thead><tr><th>Preference</th><th>Value</th></tr></thead><tbody>[% END %] > <tr class="name-row"> >- <td class="name-cell"> >+ <td id="[% FOREACH NAME IN LINE.NAMES %][% NAME.name %][% END %]" class="name-cell"> > <code> > [% FOREACH NAME IN LINE.NAMES %] >- <label for="pref_[% NAME.name | html %]"> >+ <label class="offset_anchor" for="pref_[% NAME.name | html %]"> > [% IF ( NAME.jumped ) %] >- <span class="term" id="jumped">[% NAME.name | html %]</span> >+ <span class="term" id="jumped"><a href="?tab=[% TAB.tab_id %]#[% NAME.name %]">[% NAME.name | html %]</a></span> > [% ELSIF ( NAME.highlighted ) %] >- <span class="term">[% NAME.name | html %]</span> >+ <span class="term"><a href="?tab=[% TAB.tab_id %]#[% NAME.name %]">[% NAME.name | html %]</a></span> > [% ELSE %] >- [% NAME.name | html %] >+ <a href="?tab=[% TAB.tab_id %]#[% NAME.name %]">[% NAME.name | html %]</a> > [% END %] > > [% IF NAME.overridden %] >-- >2.7.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 23388
:
91840
|
91841
| 91846 |
91847
|
94368