Bugzilla – Attachment 91943 Details for
Bug 14549
Hold not removed when item is checked out to patron who is not next in priority list
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 14549: POD and variable cleanup
Bug-14549-POD-and-variable-cleanup.patch (text/plain), 2.03 KB, created by
Tomás Cohen Arazi (tcohen)
on 2019-08-02 19:44:28 UTC
(
hide
)
Description:
Bug 14549: POD and variable cleanup
Filename:
MIME Type:
Creator:
Tomás Cohen Arazi (tcohen)
Created:
2019-08-02 19:44:28 UTC
Size:
2.03 KB
patch
obsolete
>From ab2bb1513449ddfcae0398bc8a351232d98a61ed Mon Sep 17 00:00:00 2001 >From: Nick Clemens <nick@bywatersolutions.com> >Date: Fri, 28 Jun 2019 12:53:20 +0000 >Subject: [PATCH] Bug 14549: POD and variable cleanup > >Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> >Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> >--- > C4/Reserves.pm | 15 +++++++++++---- > 1 file changed, 11 insertions(+), 4 deletions(-) > >diff --git a/C4/Reserves.pm b/C4/Reserves.pm >index b54b41d39a..8c9d66096f 100644 >--- a/C4/Reserves.pm >+++ b/C4/Reserves.pm >@@ -664,9 +664,9 @@ sub GetReserveStatus { > > =head2 CheckReserves > >- ($status, $reserve, $all_reserves) = &CheckReserves($itemnumber); >- ($status, $reserve, $all_reserves) = &CheckReserves(undef, $barcode); >- ($status, $reserve, $all_reserves) = &CheckReserves($itemnumber,undef,$lookahead); >+ ($status, $matched_reserve, $possible_reserves) = &CheckReserves($itemnumber); >+ ($status, $matched_reserve, $possible_reserves) = &CheckReserves(undef, $barcode); >+ ($status, $matched_reserve, $possible_reserves) = &CheckReserves($itemnumber,undef,$lookahead); > > Find a book in the reserves. > >@@ -1511,6 +1511,13 @@ C<@results> is an array of references-to-hash whose keys are mostly > fields from the reserves table of the Koha database, plus > C<biblioitemnumber>. > >+This routine with either return: >+1 - Item specific holds from the holds queue >+2 - Title level holds from the holds queue >+3 - All holds for this biblionumber >+ >+All return values will respect any borrowernumbers passed as arrayref in $ignore_borrowers >+ > =cut > > sub _Findgroupreserve { >@@ -1779,7 +1786,7 @@ sub MoveReserve { > my ( $itemnumber, $borrowernumber, $cancelreserve ) = @_; > > my $lookahead = C4::Context->preference('ConfirmFutureHolds'); #number of days to look for future holds >- my ( $restype, $res, $all_reserves ) = CheckReserves( $itemnumber, undef, $lookahead ); >+ my ( $restype, $res, undef ) = CheckReserves( $itemnumber, undef, $lookahead ); > return unless $res; > > my $biblionumber = $res->{biblionumber}; >-- >2.22.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 14549
:
41048
|
91067
|
91068
|
91069
|
91776
|
91777
|
91778
|
91941
|
91942
| 91943