Bugzilla – Attachment 92215 Details for
Bug 23329
tracklinks.pl accepts any url from a parameter for proxying if not tracking
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 23329: (QA follow-up) Resolve warning on wrong biblionumber
Bug-23329-QA-follow-up-Resolve-warning-on-wrong-bi.patch (text/plain), 1.28 KB, created by
Martin Renvoize (ashimema)
on 2019-08-15 07:57:46 UTC
(
hide
)
Description:
Bug 23329: (QA follow-up) Resolve warning on wrong biblionumber
Filename:
MIME Type:
Creator:
Martin Renvoize (ashimema)
Created:
2019-08-15 07:57:46 UTC
Size:
1.28 KB
patch
obsolete
>From bf9baf29835167f5c407c4c598eb3b81bb1de43b Mon Sep 17 00:00:00 2001 >From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >Date: Fri, 9 Aug 2019 09:27:18 +0000 >Subject: [PATCH] Bug 23329: (QA follow-up) Resolve warning on wrong > biblionumber > >Passing a wrong biblionumber generates a warning: > GetMarcUrls called on undefined record at opac/tracklinks.pl line 58. > >Test plan: >[1] Try it again with a wrong biblionumber and check the logs. > >Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> >--- > opac/tracklinks.pl | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/opac/tracklinks.pl b/opac/tracklinks.pl >index 09afd3209a..26b8a12a87 100755 >--- a/opac/tracklinks.pl >+++ b/opac/tracklinks.pl >@@ -55,7 +55,7 @@ if ($uri && ($biblionumber || $itemnumber) ) { > } > > my $record = C4::Biblio::GetMarcBiblio({ biblionumber => $biblionumber }); >- my $marc_urls = C4::Biblio::GetMarcUrls($record, C4::Context->preference('marcflavour')); >+ my $marc_urls = $record ? C4::Biblio::GetMarcUrls($record, C4::Context->preference('marcflavour')) : []; > my $search_crit = { uri => $uri }; > if( $itemnumber ) { # itemnumber is leading over biblionumber > $search_crit->{itemnumber} = $itemnumber; >-- >2.20.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 23329
:
91566
|
91572
|
91573
|
91759
|
91760
|
92109
|
92110
|
92111
|
92112
|
92187
|
92188
|
92198
|
92199
|
92200
|
92212
|
92213
|
92214
|
92215
|
92216
|
92217
|
92218
|
92219
|
92220
|
92223
|
92224
|
92225
|
92226
|
92227
|
92228
|
92229
|
92230
|
92231
|
92262
|
92263
|
92264
|
92265
|
92266
|
92267
|
92268
|
92269