Bugzilla – Attachment 92255 Details for
Bug 23324
Need an ISBN normalization routine
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 23324: (QA follow-up) Typo and remove unneeded use statement
Bug-23324-QA-follow-up-Typo-and-remove-unneeded-us.patch (text/plain), 1.23 KB, created by
Marcel de Rooy
on 2019-08-16 06:09:48 UTC
(
hide
)
Description:
Bug 23324: (QA follow-up) Typo and remove unneeded use statement
Filename:
MIME Type:
Creator:
Marcel de Rooy
Created:
2019-08-16 06:09:48 UTC
Size:
1.23 KB
patch
obsolete
>From 81919a51ea9535d92ec6fc05d2c8292c4a184b20 Mon Sep 17 00:00:00 2001 >From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >Date: Fri, 16 Aug 2019 06:03:55 +0000 >Subject: [PATCH] Bug 23324: (QA follow-up) Typo and remove unneeded use > statement >Content-Type: text/plain; charset=utf-8 > >Two typos in POD typo for routine name. >Remove "use Business::ISBN" from Normalize.pm. > >Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >--- > C4/Koha.pm | 4 ++-- > Koha/Util/Normalize.pm | 1 - > 2 files changed, 2 insertions(+), 3 deletions(-) > >diff --git a/C4/Koha.pm b/C4/Koha.pm >index 2493467fff..9894a060cf 100644 >--- a/C4/Koha.pm >+++ b/C4/Koha.pm >@@ -823,9 +823,9 @@ sub _isbn_cleanup { > ) if $isbn; > } > >-=head2 NormalizedISBN >+=head2 NormalizeISBN > >- my $isbns = NormalizedISBN({ >+ my $isbns = NormalizeISBN({ > isbn => $isbn, > strip_hyphens => [0,1], > format => ['ISBN-10', 'ISBN-13'] >diff --git a/Koha/Util/Normalize.pm b/Koha/Util/Normalize.pm >index 7fe4179506..af913b9743 100644 >--- a/Koha/Util/Normalize.pm >+++ b/Koha/Util/Normalize.pm >@@ -18,7 +18,6 @@ package Koha::Util::Normalize; > # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. > > use Modern::Perl; >-use Business::ISBN; > > use parent qw( Exporter ); > >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 23324
:
91550
|
91551
|
91557
|
92116
|
92253
|
92254
| 92255