Bugzilla – Attachment 92261 Details for
Bug 23445
Loan period unit in circulation rules is untranslatable causing problems when editing rules
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 23445: Make loan period unit translatable fixing editing issue
Bug-23445-Make-loan-period-unit-translatable-fixin.patch (text/plain), 2.46 KB, created by
Marcel de Rooy
on 2019-08-16 09:00:41 UTC
(
hide
)
Description:
Bug 23445: Make loan period unit translatable fixing editing issue
Filename:
MIME Type:
Creator:
Marcel de Rooy
Created:
2019-08-16 09:00:41 UTC
Size:
2.46 KB
patch
obsolete
>From 97b8ec21d500f4127f33145136fbf2fc9dd76d39 Mon Sep 17 00:00:00 2001 >From: Katrin Fischer <katrin.fischer.83@web.de> >Date: Fri, 9 Aug 2019 15:49:34 +0000 >Subject: [PATCH] Bug 23445: Make loan period unit translatable fixing editing > issue >Content-Type: text/plain; charset=utf-8 > >In the circulation rules, the loan period displayed in the table >of circulation rules is not translatable, always displaying in English. >This causes an issue when editing a circ rule with unit hours in any >other language than English. >When editing these rules, instead of hours, days will be preselected. > >To test: >- Before applying the patch: >- Install a translation >- Activate and switch to the tranlation >- Create a circulation rule using 'hours' as the unit >- Edit the circulation rule >- Verify that instead of 'hours' 'days' will be selected in the pull-down >- Apply patch >- Update po files (kshell, cd misc/translator, perl translate update <langcode>) >- Edit po file <langcode-staff..., search for Hours and translate line, > make sure to also remove fuzzy, and that your translation matches the > pull down values for your language >- Reinstall translation >- Repeat circ rule edit test >- Verify the unit now shows up with your translation and editing works > >Signed-off-by: Owen Leonard <oleonard@myacpl.org> > >Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >--- > koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt | 8 +++++++- > 1 file changed, 7 insertions(+), 1 deletion(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt >index dc09354f6e..ed8bc3034e 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt >@@ -154,7 +154,13 @@ > </td> > <td>[% rule.issuelength | html %]</td> > <td> >- [% rule.lengthunit | html %] >+ [% IF ( rule.lengthunit == 'days' ) %] >+ Days >+ [% ELSIF ( rule.lengthunit == 'hours') %] >+ Hours >+ [% ELSE %] >+ Undefined >+ [% END %] > </td> > <td> > [% IF ( rule.hardduedate ) %] >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 23445
:
92137
|
92240
| 92261 |
92270