Attachment 92310 Details for Bug 14570 – Bug 14570: (QA follow-up) Consistency displaying the list of guarantors

[patch] Bug 14570: (QA follow-up) Consistency displaying the list of guarantors

Bug-14570-QA-follow-up-Consistency-displaying-the-.patch (text/plain), 3.03 KB, created by Liz Rea on 2019-08-16 19:21:43 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Liz Rea

Created: 2019-08-16 19:21:43 UTC

Size: 3.03 KB

patch

obsolete

>From 56235fef13f23e4d9aa8ec4ffab4200d581bf983 Mon Sep 17 00:00:00 2001
>From: Tomas Cohen Arazi <tomascohen@theke.io>
>Date: Mon, 12 Aug 2019 17:14:22 -0300
>Subject: [PATCH] Bug 14570: (QA follow-up) Consistency displaying the list of
> guarantors
>
>Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
>
>Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
>Signed-off-by: Agustin Moyano <agustinmoyano@theke.io>
>
>Signed-off-by: Liz Rea <wizzyrea@gmail.com>
>---
> .../intranet-tmpl/prog/en/modules/members/moremember.tt  | 16 +++++++++++-----
> 1 file changed, 11 insertions(+), 5 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt
>index 8076459074..090c608845 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt
>@@ -271,15 +271,21 @@
>                                                 </ul>
>                                             </li>
>                                         [% ELSIF guarantor_relationships %]
>-                                            [% FOREACH gr IN guarantor_relationships %]
>                                                 <li>
>+                                                [% IF guarantor_relationships.count > 1 %]
>+                                                    <span class="label">Guarantors:</span>
>+                                                [% ELSE %]
>                                                     <span class="label">Guarantor:</span>
>-                                                    [% SET guarantor = gr.guarantor %]
>-                                                    [% IF logged_in_user.can_see_patron_infos( guarantor ) %]
>-                                                        <a href="/cgi-bin/koha/members/moremember.pl?borrowernumber=[% guarantor.id | uri %]">[% guarantor.firstname | html %] [% guarantor.surname | html %]</a>
>+                                                [% END %]
>+                                                    <ul>
>+                                                    [% FOREACH gr IN guarantor_relationships %]
>+                                                        [% SET guarantor = gr.guarantor %]
>+                                                        [% IF logged_in_user.can_see_patron_infos( guarantor ) %]
>+                                                            <li><a href="/cgi-bin/koha/members/moremember.pl?borrowernumber=[% guarantor.id | uri %]">[% guarantor.firstname | html %] [% guarantor.surname | html %]</a></li>
>+                                                        [% END %]
>                                                     [% END %]
>+                                                    </ul>
>                                                 </li>
>-                                            [% END %]
>                                         [% END %]
>                                     </ol>
>                                 </div> [% # /div.rows %]
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 14570: 52400 | 52401 | 52402 | 52403 | 52406 | 52407 | 58146 | 58147 | 58159 | 58202 | 58391 | 58399 | 58412 | 58688 | 58689 | 58739 | 58762 | 58763 | 58764 | 58834 | 58835 | 58836 | 58837 | 58838 | 58839 | 58949 | 58950 | 58951 | 58952 | 58953 | 58954 | 58972 | 58973 | 58974 | 58975 | 58976 | 58977 | 58978 | 58979 | 58980 | 62450 | 62451 | 62452 | 64124 | 64125 | 64126 | 71160 | 71161 | 71162 | 71163 | 73283 | 73284 | 73583 | 73584 | 74950 | 74951 | 74952 | 74953 | 74954 | 74976 | 74977 | 74978 | 74979 | 77029 | 77030 | 77031 | 77032 | 77033 | 77034 | 77040 | 77041 | 77042 | 77043 | 77044 | 77045 | 77046 | 77047 | 77048 | 77049 | 77067 | 77068 | 77069 | 77070 | 77071 | 77072 | 77073 | 77074 | 77075 | 77076 | 77077 | 77078 | 77290 | 77291 | 77346 | 77347 | 77348 | 80842 | 80849 | 81932 | 81933 | 85411 | 85412 | 85431 | 89889 | 89890 | 89891 | 89892 | 89909 | 89910 | 89911 | 89912 | 89921 | 89922 | 89929 | 90048 | 91231 | 91439 | 91440 | 91441 | 91442 | 91443 | 91444 | 91445 | 91694 | 91695 | 91696 | 91697 | 91698 | 91699 | 91700 | 92157 | 92158 | 92161 | 92162 | 92163 | 92180 | 92181 | 92182 | 92183 | 92232 | 92233 | 92234 | 92235 | 92277 | 92278 | 92279 | 92280 | 92281 | 92282 | 92283 | 92284 | 92285 | 92286 | 92287 | 92288 | 92289 | 92290 | 92291 | 92292 | 92298 | 92299 | 92300 | 92301 | 92302 | 92303 | 92304 | 92305 | 92306 | 92307 | 92308 | 92309 | 92310 | 92311 | 92312 | 92313 | 92314 | 92315 | 92316 | 92317 | 92318 | 92319 | 92320 | 92321 | 92322 | 92323 | 92324 | 92325 | 92346 | 92347 | 92348 | 92349 | 92350