Bugzilla – Attachment 92330 Details for
Bug 17057
Remove event attributes from holds template
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 17057: (follow-up) Replace onsubmit attributes
Bug-17057-follow-up-Replace-onsubmit-attributes.patch (text/plain), 2.49 KB, created by
Katrin Fischer
on 2019-08-17 05:57:29 UTC
(
hide
)
Description:
Bug 17057: (follow-up) Replace onsubmit attributes
Filename:
MIME Type:
Creator:
Katrin Fischer
Created:
2019-08-17 05:57:29 UTC
Size:
2.49 KB
patch
obsolete
>From bc92f0b830fa11166225b5170e598dee21ba45ca Mon Sep 17 00:00:00 2001 >From: Owen Leonard <oleonard@myacpl.org> >Date: Tue, 13 Aug 2019 15:54:30 +0000 >Subject: [PATCH] Bug 17057: (follow-up) Replace onsubmit attributes > >This patch removes the "onsubmit" attribute from the place hold form. > >To test, apply the patch and test placing a hold: > >Begin the process of placing a hold on a single title. On the >place hold screen, uncheck the "Hold next available item" checkbox and >click the "Place hold" button. > >You should be get an alert saying "Please select an item to place a >hold." Select an item and click the "Place hold" button again. The hold >should be placed. > >This patch affects the form validation for placing multiple holds, but I >don't think the JavaScript ever has a chance to run: The template blocks >the user from placing multiple holds if one of the titles has no items. > >Signed-off-by: Maryse Simard <maryse.simard@inlibro.com> > >Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> >--- > .../intranet-tmpl/prog/en/modules/reserve/request.tt | 16 +++++++++++----- > 1 file changed, 11 insertions(+), 5 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt >index 1c10c2f94d..96fc32d7a4 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt >@@ -167,11 +167,7 @@ > > <fieldset class="rows left"> > <legend>Hold details</legend> >- [% UNLESS ( multi_hold ) %] >- <form action="placerequest.pl" method="post" onsubmit="return check();" name="form" id="hold-request-form"> >- [% ELSE %] >- <form action="placerequest.pl" method="post" onsubmit="return checkMultiHold();" name="form"> >- [% END %] >+ <form action="placerequest.pl" method="post" name="form" id="hold-request-form"> > > <input type="hidden" name="borrowernumber" value="[% patron.borrowernumber | html %]" /> > <input type="hidden" name="type" value="str8" /> >@@ -747,6 +743,16 @@ > "margin-right":"0em" > }); > >+ [% UNLESS ( multi_hold ) %] >+ $("#hold-request-form").on("submit", function(){ >+ return check(); >+ }); >+ [% ELSE %] >+ $("#hold-request-form").on("submit", function(){ >+ return checkMultiHold(); >+ }); >+ [% END %] >+ > }); > > function check() { >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 17057
:
54055
|
54072
|
54109
|
92178
|
92179
|
92293
|
92294
|
92329
| 92330