Attachment 92348 Details for Bug 14570 – Bug 14570: Handle missing 'relationship' in atomicupdate (bad data)

[patch] Bug 14570: Handle missing 'relationship' in atomicupdate (bad data)

Bug-14570-Handle-missing-relationship-in-atomicupd.patch (text/plain), 2.05 KB, created by Tomás Cohen Arazi (tcohen) on 2019-08-19 15:20:09 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Tomás Cohen Arazi (tcohen)

Created: 2019-08-19 15:20:09 UTC

Size: 2.05 KB

patch

obsolete

>From 43475232c3ebbb57d0090548105efd98648cad8a Mon Sep 17 00:00:00 2001
>From: Tomas Cohen Arazi <tomascohen@theke.io>
>Date: Mon, 19 Aug 2019 07:22:50 -0300
>Subject: [PATCH] Bug 14570: Handle missing 'relationship' in atomicupdate (bad
> data)
>
>This patch adds two steps to the upgrade process:
>- Handle the pathologic case in which there's a guarantorid and no
>'relationship'.
>- Performs a cleanup on the relevant columns when the guarantor data
>contains a guarantorid, and is then migrated into the
>borrower_relationships table. The original code left the information
>in the borrowers table, so no clear separation between guarantors as
>patrons and the virtual ones.
>
>Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
>---
> installer/data/mysql/atomicupdate/bug_14570.perl | 16 ++++++++++++++++
> 1 file changed, 16 insertions(+)
>
>diff --git a/installer/data/mysql/atomicupdate/bug_14570.perl b/installer/data/mysql/atomicupdate/bug_14570.perl
>index c266c9b669..e3f9a6465c 100644
>--- a/installer/data/mysql/atomicupdate/bug_14570.perl
>+++ b/installer/data/mysql/atomicupdate/bug_14570.perl
>@@ -22,11 +22,27 @@ if( CheckVersion( $DBversion ) ) {
>             SET borrowers.guarantorid = NULL WHERE guarantor.borrowernumber IS NULL;
>         });
> 
>+        # Bad data handling: guarantorid IS NOT NULL AND relationship IS NULL
>+        $dbh->do(q{
>+            UPDATE borrowers
>+            SET relationship = '_bad_data'
>+            WHERE guarantorid IS NOT NULL AND
>+                  relationship IS NULL
>+        });
>+
>         $dbh->do(q{
>             INSERT INTO borrower_relationships ( guarantor_id, guarantee_id, relationship )
>             SELECT guarantorid, borrowernumber, relationship FROM borrowers WHERE guarantorid IS NOT NULL;
>         });
> 
>+        # Clean migrated guarantor data
>+        $dbh->do(q{
>+            UPDATE borrowers
>+            SET contactname=NULL,
>+                contactfirstname=NULL,
>+                relationship=NULL
>+            WHERE guarantorid IS NOT NULL
>+        });
>     }
> 
>      if( column_exists( 'borrowers', 'guarantorid' ) ) {
>-- 
>2.22.1

Actions: View | Diff | Splinter Review

Attachments on bug 14570: 52400 | 52401 | 52402 | 52403 | 52406 | 52407 | 58146 | 58147 | 58159 | 58202 | 58391 | 58399 | 58412 | 58688 | 58689 | 58739 | 58762 | 58763 | 58764 | 58834 | 58835 | 58836 | 58837 | 58838 | 58839 | 58949 | 58950 | 58951 | 58952 | 58953 | 58954 | 58972 | 58973 | 58974 | 58975 | 58976 | 58977 | 58978 | 58979 | 58980 | 62450 | 62451 | 62452 | 64124 | 64125 | 64126 | 71160 | 71161 | 71162 | 71163 | 73283 | 73284 | 73583 | 73584 | 74950 | 74951 | 74952 | 74953 | 74954 | 74976 | 74977 | 74978 | 74979 | 77029 | 77030 | 77031 | 77032 | 77033 | 77034 | 77040 | 77041 | 77042 | 77043 | 77044 | 77045 | 77046 | 77047 | 77048 | 77049 | 77067 | 77068 | 77069 | 77070 | 77071 | 77072 | 77073 | 77074 | 77075 | 77076 | 77077 | 77078 | 77290 | 77291 | 77346 | 77347 | 77348 | 80842 | 80849 | 81932 | 81933 | 85411 | 85412 | 85431 | 89889 | 89890 | 89891 | 89892 | 89909 | 89910 | 89911 | 89912 | 89921 | 89922 | 89929 | 90048 | 91231 | 91439 | 91440 | 91441 | 91442 | 91443 | 91444 | 91445 | 91694 | 91695 | 91696 | 91697 | 91698 | 91699 | 91700 | 92157 | 92158 | 92161 | 92162 | 92163 | 92180 | 92181 | 92182 | 92183 | 92232 | 92233 | 92234 | 92235 | 92277 | 92278 | 92279 | 92280 | 92281 | 92282 | 92283 | 92284 | 92285 | 92286 | 92287 | 92288 | 92289 | 92290 | 92291 | 92292 | 92298 | 92299 | 92300 | 92301 | 92302 | 92303 | 92304 | 92305 | 92306 | 92307 | 92308 | 92309 | 92310 | 92311 | 92312 | 92313 | 92314 | 92315 | 92316 | 92317 | 92318 | 92319 | 92320 | 92321 | 92322 | 92323 | 92324 | 92325 | 92346 | 92347 | 92348 | 92349 | 92350