Attachment 92367 Details for Bug 23273 – Bug 23281: Cleanup Koha::Patron::Attribute::Types->search

[patch] Bug 23281: Cleanup Koha::Patron::Attribute::Types->search

Bug-23281-Cleanup-KohaPatronAttributeTypes-search.patch (text/plain), 1.73 KB, created by Owen Leonard on 2019-08-19 23:47:46 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Owen Leonard

Created: 2019-08-19 23:47:46 UTC

Size: 1.73 KB

patch

obsolete

>From 258b0df6fc2ef23076791161186b74a8da9b39a3 Mon Sep 17 00:00:00 2001
>From: Tomas Cohen Arazi <tomascohen@theke.io>
>Date: Mon, 8 Jul 2019 15:23:09 -0300
>Subject: [PATCH] Bug 23281: Cleanup Koha::Patron::Attribute::Types->search
>
>Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
>Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
>Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>
>Signed-off-by: Owen Leonard <oleonard@myacpl.org>
>
>https://bugs.koha-community.org/show_bug.cgi?id=23273
>---
> Koha/Patron/Attribute/Types.pm | 32 ++------------------------------
> 1 file changed, 2 insertions(+), 30 deletions(-)
>
>diff --git a/Koha/Patron/Attribute/Types.pm b/Koha/Patron/Attribute/Types.pm
>index 5064fd2479..dfd9c227fa 100644
>--- a/Koha/Patron/Attribute/Types.pm
>+++ b/Koha/Patron/Attribute/Types.pm
>@@ -27,39 +27,11 @@ Koha::Patron::Attribute::Types Object set class
> 
> =head1 API
> 
>-=head2 Class Methods
>+=head2 Internal methods
> 
> =cut
> 
>-=head3 Koha::Patron::Attribute::Types->search();
>-
>-my @attribute_types = Koha::Patron::Attribute::Types->search($params);
>-
>-=cut
>-
>-sub search {
>-    my ( $self, $params, $attributes ) = @_;
>-
>-    my $branchcode = $params->{branchcode};
>-    delete( $params->{branchcode} );
>-
>-    my $or =
>-      $branchcode
>-      ? {
>-        '-or' => [
>-            'borrower_attribute_types_branches.b_branchcode' => undef,
>-            'borrower_attribute_types_branches.b_branchcode' => $branchcode,
>-        ]
>-      }
>-      : {};
>-    my $join = $branchcode ? { join => 'borrower_attribute_types_branches' } : {};
>-    $attributes //= {};
>-    $attributes = { %$attributes, %$join };
>-    return $self->SUPER::search( { %$params, %$or, }, $attributes );
>-}
>-
>-
>-=head3 type
>+=head3 _type
> 
> =cut
> 
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 23273: 92365 | 92367 | 92368 | 92372 | 92517 | 92527