Attachment 92439 Details for Bug 16111 – Bug 16111: Further fixes to the RSS to make feed work

[patch] Bug 16111: Further fixes to the RSS to make feed work

Bug-16111-Further-fixes-to-the-RSS-to-make-feed-wo.patch (text/plain), 3.65 KB, created by Owen Leonard on 2019-08-22 15:52:40 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Owen Leonard

Created: 2019-08-22 15:52:40 UTC

Size: 3.65 KB

patch

obsolete

>From 19bb896e04950c77ea25bd4adf7dc5d3c88e51a3 Mon Sep 17 00:00:00 2001
>From: Liz Rea <wizzyrea@gmail.com>
>Date: Mon, 19 Aug 2019 01:51:04 +0000
>Subject: [PATCH] Bug 16111: Further fixes to the RSS to make feed work
>
>- fixed links per the WC3 spec
>- fixed a problem in the ATOM link
>
>To test:
>do a search, click the RSS icon - it shows xml in most browsers but wont
>do RSS type things.
>Apply this patch, restart the things
>refresh the page, it should do RSS things (i.e. firefox should render it
>        as a nice looking thing, rather than raw XML.)
>
>noting that there are a couple of validation errors still, but they
>don't seem to be show stopping and moreover I wasn't sure how to fix them:
>
>Misplaced Item
>Self reference doesn't match document location (this is a "for widest
>        compatibility you should fix" kind of thing)
>
>Signed-off-by: Owen Leonard <oleonard@myacpl.org>
>---
> koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-opensearch.tt | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
>diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-opensearch.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-opensearch.tt
>index 5496dec0c5b..bc26e9db5d0 100644
>--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-opensearch.tt
>+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-opensearch.tt
>@@ -24,7 +24,7 @@
>    <channel>
>      <title><![CDATA[[% LibraryName | html %] Search [% IF ( query_desc ) %]for '[% query_desc | html %]'[% END %][% IF ( limit_desc ) %] with limit(s): '[% limit_desc | html %]'[% END %]]]></title>
>      <link>[% OPACBaseURL | html %]/cgi-bin/koha/opac-search.pl?[% query_cgi | $raw %][% limit_cgi | $raw %]&amp;format=rss</link>
>-     <atom:link rel="self" type="application/rss+xml" href="[% OPACBaseURL | url %]/cgi-bin/koha/opac-search.pl?[% query_cgi | $raw %][% limit_cgi | $raw %]&amp;sort_by=[% sort_by | uri %]&amp;format=atom"/>
>+     <atom:link rel="self" type="application/rss+xml" href="[% OPACBaseURL | url %]/cgi-bin/koha/opac-search.pl?[% SEARCH_RESULT.query_cgi | $raw %][% SEARCH_RESULT.limit_cgi | $raw %]&amp;sort_by=[% sort_by | uri %]&amp;format=atom"/>
>      <description><![CDATA[ Search results [% IF ( query_desc ) %]for '[% query_desc | html %]'[% END %][% IF ( limit_desc ) %] with limit(s): '[% limit_desc | html %]'[% END %] at [% LibraryName | html %]]]></description>
>      <opensearch:totalResults>[% total | html %]</opensearch:totalResults>
>      <opensearch:startIndex>[% offset | html %]</opensearch:startIndex>
>@@ -40,11 +40,11 @@
>        <title>[% INCLUDE 'biblio-title-head.inc' biblio=SEARCH_RESULT %]</title>
>        <dc:identifier>ISBN [% SEARCH_RESULT.isbn | html %]</dc:identifier>
>         [% IF ( SEARCH_RESULT.BiblioDefaultViewmarc ) %]
>-            <link href="[% OPACBaseURL | url %]/cgi-bin/koha/opac-MARCdetail.pl?biblionumber=[% SEARCH_RESULT.biblionumber | uri %]" />
>+        <link>[% OPACBaseURL | url %]/cgi-bin/koha/opac-MARCdetail.pl?biblionumber=[% SEARCH_RESULT.biblionumber | uri %]</link>
>         [% ELSIF ( SEARCH_RESULT.BiblioDefaultViewisbd ) %]
>-            <link href="[% OPACBaseURL | url %]/cgi-bin/koha/opac-ISBDdetail.pl?biblionumber=[% SEARCH_RESULT.biblionumber | uri %]" />
>+        <link>[% OPACBaseURL | url %]/cgi-bin/koha/opac-ISBDdetail.pl?biblionumber=[% SEARCH_RESULT.biblionumber | uri %]</link>
>         [% ELSE %]
>-            <link href="[% OPACBaseURL | url %]/cgi-bin/koha/opac-detail.pl?biblionumber=[% SEARCH_RESULT.biblionumber | uri %]" />
>+        <link>[% OPACBaseURL | url %]/cgi-bin/koha/opac-detail.pl?biblionumber=[% SEARCH_RESULT.biblionumber | uri %]</link>
>         [% END %]
>        <description><![CDATA[
> [% IF ( AdlibrisEnabled && SEARCH_RESULT.normalized_isbn ) %]
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 16111: 49400 | 49587 | 49629 | 49837 | 76148 | 76160 | 76161 | 76162 | 77057 | 77058 | 77059 | 77060 | 78578 | 78579 | 78580 | 78581 | 78689 | 81285 | 81286 | 81287 | 81288 | 92050 | 92362 | 92363 | 92366 | 92435 | 92436 | 92437 | 92438 | 92439 | 92618 | 92619 | 92620 | 92621 | 92622 | 92623 | 92624