Bugzilla – Attachment 92458 Details for
Bug 23502
Staff client "revert status" buttons should not depend on SuspendHoldsIntranet preference
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 23502: Staff client "revert status" buttons should not depend on SuspendHoldsIntranet preference
Bug-23502-Staff-client-revert-status-buttons-shoul.patch (text/plain), 4.57 KB, created by
Owen Leonard
on 2019-08-23 16:52:28 UTC
(
hide
)
Description:
Bug 23502: Staff client "revert status" buttons should not depend on SuspendHoldsIntranet preference
Filename:
MIME Type:
Creator:
Owen Leonard
Created:
2019-08-23 16:52:28 UTC
Size:
4.57 KB
patch
obsolete
>From ebab4e790f5d4f0159603423fc171d64008eb08f Mon Sep 17 00:00:00 2001 >From: Owen Leonard <oleonard@myacpl.org> >Date: Fri, 23 Aug 2019 16:41:57 +0000 >Subject: [PATCH] Bug 23502: Staff client "revert status" buttons should not > depend on SuspendHoldsIntranet preference > >This bug corrects the template logic controlling the display of the >"Revert waiting status" and "Revert transit status" buttons on the staff >client holds page so that it doesn't depend on having >SuspendHoldsIntranet enabled. > >To test, apply the patch and locate a title which has multiple holds, >including: > > - One waiting hold > - One in-transit hold > - At least one pending hold > >View the page with the SuspendHoldsIntranet preference both on and off. >The "Revert transit status" and "Revert waiting status" buttons should >be displayed either way. >--- > .../intranet-tmpl/prog/en/includes/holds_table.inc | 19 ++++++++++--------- > 1 file changed, 10 insertions(+), 9 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/holds_table.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/holds_table.inc >index 0e0462d2321..c40d3e638b5 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/includes/holds_table.inc >+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/holds_table.inc >@@ -17,7 +17,7 @@ > <th><img src="[% interface | html %]/[% theme | html %]/img/go-bottom.png" alt="Toggle set to lowest priority" /></th> > [% END %] > <th> </th> >- [% IF SuspendHoldsIntranet %]<th> </th><!-- Suspend Holds Column Header -->[% END %] >+ <th> </th> > </tr> > > [% SET first_priority = 0 %] >@@ -188,24 +188,25 @@ > </a> > </td> > >- [% IF SuspendHoldsIntranet %] >- <td> >+ <td> >+ [% IF Koha.Preference('SuspendHoldsIntranet') %] > [% UNLESS ( hold.found ) %] > <input type="button" value="[% IF ( hold.suspend ) %]Unsuspend[% ELSE %]Suspend[% END %]" onclick="window.location.href='request.pl?action=toggleSuspend&reserve_id=[% hold.reserve_id | html %]&borrowernumber=[% hold.borrowernumber | html %]&biblionumber=[% hold.biblionumber | html %]&date=[% hold.date | html %]&suspend_until=' + $('#suspend_until_[% hold.reserve_id | html %]').val()" /> > >- [% IF AutoResumeSuspendedHolds %] >+ [% IF Koha.Preference('AutoResumeSuspendedHolds') %] > <label for="suspend_until_[% hold.reserve_id | html %]">[% IF ( hold.suspend ) %] on [% ELSE %] until [% END %]</label> > <input type="text" name="suspend_until" id="suspend_until_[% hold.reserve_id | html %]" size="10" value="[% hold.suspend_until | $KohaDates %]" class="datepicker suspend_until_datepicker" /> > <a href='#' onclick="document.getElementById('suspend_until_[% hold.reserve_id | html %]').value='';">Clear date</a> > [% ELSE %] > <input type="hidden" name="suspend_until" id="suspend_until_[% hold.reserve_id | html %]" value=""/> > [% END %] >- >- [% ELSE %] >- <input type="button" id="revert_hold_[% hold.reserve_id | html %]" value="[% IF hold.intransit %]Revert transit status[% ELSE %]Revert waiting status[% END %]" onclick="window.location.href='request.pl?action=move&where=down&first_priority=[% first_priority | uri %]&last_priority=[% last_priority | uri %]&prev_priority=0&next_priority=1&borrowernumber=[% hold.borrowernumber | uri %]&biblionumber=[% hold.biblionumber | uri %]&itemnumber=[% hold.itemnumber | uri %]&reserve_id=[% hold.reserve_id | uri %]&date=[% hold.date | uri %]'"> > [% END %] >- </td> >- [% END # IF SuspendHoldsIntranet %] >+ [% END # IF SuspendHoldsIntranet %] >+ >+ [% IF ( hold.found ) %] >+ <input type="button" id="revert_hold_[% hold.reserve_id | html %]" value="[% IF hold.intransit %]Revert transit status[% ELSE %]Revert waiting status[% END %]" onclick="window.location.href='request.pl?action=move&where=down&first_priority=[% first_priority | uri %]&last_priority=[% last_priority | uri %]&prev_priority=0&next_priority=1&borrowernumber=[% hold.borrowernumber | uri %]&biblionumber=[% hold.biblionumber | uri %]&itemnumber=[% hold.itemnumber | uri %]&reserve_id=[% hold.reserve_id | uri %]&date=[% hold.date | uri %]'"> >+ [% END %] >+ </td> > > </tr> > >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 23502
:
92458
|
92466
|
92508