Attachment 92513 Details for Bug 23210 – Bug 23210: (follow-up) Log in for tags link should trigger modal

[patch] Bug 23210: (follow-up) Log in for tags link should trigger modal

Bug-23210-follow-up-Log-in-for-tags-link-should-tr.patch (text/plain), 1.95 KB, created by Michal Denar on 2019-08-30 19:45:52 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Michal Denar

Created: 2019-08-30 19:45:52 UTC

Size: 1.95 KB

patch

obsolete

>From 33f0391566bba0cece0f3a7ba491c655b9575674 Mon Sep 17 00:00:00 2001
>From: Owen Leonard <oleonard@myacpl.org>
>Date: Mon, 5 Aug 2019 14:25:51 +0000
>Subject: [PATCH] Bug 23210: (follow-up) Log in for tags link should trigger
> modal
>
>This patch modifies the "Log in to add tags" link on the OPAC search
>results page, adding the class which is used elsewhere in the OPAC
>templates for triggering the login modal.
>
>Also: Removed an unnecessary period.
>
>To test, apply the patch and follow the original test plan. Clicking the
>"Log in to add tags" link should trigger the login modal. After logging
>in you should be returned to the page you were on.
>
>Signed-off-by: Michal Denar <black23@gmail.com>
>
>Signed-off-by: Michal Denar <black23@gmail.com>
>---
> koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt
>index e92e38c57e..6e737317a5 100644
>--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt
>+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt
>@@ -555,7 +555,7 @@
> Tag status here.
> 
> [% ELSIF ( loop.first ) %]
>- <a href="/cgi-bin/koha/opac-user.pl">Log in to add tags.</a>
>+ <a class="loginModal-trigger" href="/cgi-bin/koha/opac-user.pl">Log in to add tags</a>
> [% END # IF loggedinusername %]
> [% END # if TagsInputEnabled %]
> 
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 23210: 91945 | 91998 | 91999 | 92512 | 92513 | 92518 | 92519 | 92522 | 92523